Issue 429633004: Test NSSCertDatabaseChromeOS in the presence of the system slot.

Issue 429633004: Test NSSCertDatabaseChromeOS in the presence of the system slot. (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
mattm

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Test NSSCertDatabaseChromeOS in the presence of the system slot. Depends on: https://codereview.chromium.org/424523002/ BUG=210525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287209

Patch Set 2 : Fixed a comment. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -49 lines)			Patch
M	net/cert/nss_cert_database_chromeos_unittest.cc	View		4 chunks	+40 lines, -0 lines	0 comments	Download
M	net/ssl/client_cert_store_chromeos_unittest.cc	View		5 chunks	+6 lines, -49 lines	0 comments	Download
M	net/test/cert_test_util.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	net/test/cert_test_util_nss.cc	View	1	2 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

Unit tests splitted out of https://codereview.chromium.org/424523002/ .

6 years, 4 months ago (2014-07-29 18:12:01 UTC) #1

mattm

https://codereview.chromium.org/429633004/diff/20001/net/test/cert_test_util_nss.cc File net/test/cert_test_util_nss.cc (right): https://codereview.chromium.org/429633004/diff/20001/net/test/cert_test_util_nss.cc#newcode84 net/test/cert_test_util_nss.cc:84: // test. "this test" doesn't make sense in util ...

6 years, 4 months ago (2014-07-31 20:26:19 UTC) #2

pneubeck (no reviews)

The CQ bit was checked by pneubeck@chromium.org

6 years, 4 months ago (2014-08-02 07:52:38 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/429633004/40001

6 years, 4 months ago (2014-08-02 07:54:03 UTC) #6

Message was sent while issue was closed.

Change committed as 287209

Expand Messages | Collapse Messages