Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 429523002: IDL: Make caching lex table robust (Closed)

Created:
6 years, 4 months ago by bashi
Modified:
6 years, 4 months ago
Reviewers:
haraken, Nico
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, Nils Barth (inactive)
Project:
blink
Visibility:
Public.

Description

IDL: Make caching lex table robust We run blink_idl_parser.py to cache parse table and lex table. When the generated lextab.py is removed but its .pyc file still exists for some reason, "blink_tests" target nerver becomes clean. To avoid this, remove lextab.py and .pyc. BUG=397909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M Source/bindings/scripts/blink_idl_parser.py View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bashi
Haraken-san, PTAL?
6 years, 4 months ago (2014-07-29 09:39:42 UTC) #1
bashi
On 2014/07/29 09:39:42, bashi1 wrote: > Haraken-san, PTAL? Closing as jl@ did the same thing. ...
6 years, 4 months ago (2014-07-29 09:58:11 UTC) #2
bashi
6 years, 4 months ago (2014-07-29 09:58:12 UTC) #3
On 2014/07/29 09:39:42, bashi1 wrote:
> Haraken-san, PTAL?

Closing as jl@ did the same thing.
https://codereview.chromium.org/425953002/

Powered by Google App Engine
This is Rietveld 408576698