Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 429453004: Let FrameSelection::localCaretRect on a text input field avoid synchronous layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index a5ec11bf2d5d76146cbab5f419b8de9404ac786b..2dd79ab5e68c9dde67d2567d7abfd6cf6ec298b0 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -649,24 +649,8 @@ UChar32 VisiblePosition::characterAfter() const
LayoutRect VisiblePosition::localCaretRect(RenderObject*& renderer) const
{
- if (m_deepPosition.isNull()) {
- renderer = 0;
- return IntRect();
- }
- Node* node = m_deepPosition.anchorNode();
-
- renderer = node->renderer();
- if (!renderer)
- return LayoutRect();
-
- InlineBox* inlineBox;
- int caretOffset;
- getInlineBoxAndOffset(inlineBox, caretOffset);
-
- if (inlineBox)
- renderer = &inlineBox->renderer();
-
- return renderer->localCaretRect(inlineBox, caretOffset);
+ PositionWithAffinity positionWithAffinity(m_deepPosition, m_affinity);
+ return localCaretRectOfPosition(positionWithAffinity, renderer);
}
IntRect VisiblePosition::absoluteCaretBounds() const

Powered by Google App Engine
This is Rietveld 408576698