Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: Source/core/editing/Caret.h

Issue 429453004: Let FrameSelection::localCaretRect on a text input field avoid synchronous layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/Caret.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Caret.h
diff --git a/Source/core/editing/Caret.h b/Source/core/editing/Caret.h
index 34febde4c89cd0703561c6358c5baa17fb418003..728f36e852e7cc07caa0ee9adfdaa5f4687d692c 100644
--- a/Source/core/editing/Caret.h
+++ b/Source/core/editing/Caret.h
@@ -35,6 +35,7 @@ namespace blink {
class LocalFrame;
class GraphicsContext;
+class PositionWithAffinity;
class RenderBlock;
class RenderView;
@@ -47,6 +48,8 @@ protected:
void invalidateCaretRect(Node*, bool caretRectChanged = false);
void clearCaretRect();
+ bool updateCaretRect(Document*, const PositionWithAffinity& caretPosition);
+ // Simply calls above updateCaretRect using deepEquivalent() and affinity().
tkent 2014/07/30 00:29:33 This comment is not helpful. Please write a commen
bool updateCaretRect(Document*, const VisiblePosition& caretPosition);
IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&) const;
bool shouldRepaintCaret(const RenderView*, bool isContentEditable) const;
« no previous file with comments | « no previous file | Source/core/editing/Caret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698