Source/core/editing/VisibleUnits.h - Issue 429453004: Let FrameSelection::localCaretRect on a text input field avoid synchronous layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleUnits.h

Issue 429453004: Let FrameSelection::localCaretRect on a text input field avoid synchronous layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move localCaretRect to VisibleUnits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/Caret.h ('K') | « Source/core/editing/VisiblePosition.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | Source/core/html/HTMLTextFormControlElementTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/VisibleUnits.h

diff --git a/Source/core/editing/VisibleUnits.h b/Source/core/editing/VisibleUnits.h

index f07826032ed9218e0bb717c0933e79dcf2b07f94..665f55fcc93de27eefb6a627f23887b817473b6c 100644

--- a/Source/core/editing/VisibleUnits.h

+++ b/Source/core/editing/VisibleUnits.h

@@ -31,6 +31,9 @@

namespace blink {

+class LayoutRect;

+class PositionWithAffinity;

+class RenderObject;

class Node;

class VisiblePosition;

@@ -93,6 +96,9 @@ VisiblePosition startOfEditableContent(const VisiblePosition&);

VisiblePosition endOfEditableContent(const VisiblePosition&);

bool isEndOfEditableOrNonEditableContent(const VisiblePosition&);

+// Rect is local to the returned renderer

yosin_UTC9 2014/07/29 09:09:02 Oops, sorry this function is only used in VisibleP

+LayoutRect localCaretRectOfPosition(const PositionWithAffinity&, RenderObject*&);

} // namespace blink

#endif // VisibleUnits_h

« Source/core/editing/Caret.h ('K') | « Source/core/editing/VisiblePosition.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | Source/core/html/HTMLTextFormControlElementTest.cpp » ('J')