Source/core/editing/Caret.h - Issue 429453004: Let FrameSelection::localCaretRect on a text input field avoid synchronous layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Caret.h

Issue 429453004: Let FrameSelection::localCaretRect on a text input field avoid synchronous layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move localCaretRect to VisibleUnits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Caret.h

diff --git a/Source/core/editing/Caret.h b/Source/core/editing/Caret.h

index 34febde4c89cd0703561c6358c5baa17fb418003..8caa9b2ac39533357119386be9362447523e8a08 100644

--- a/Source/core/editing/Caret.h

+++ b/Source/core/editing/Caret.h

@@ -35,6 +35,7 @@ namespace blink {

class LocalFrame;

class GraphicsContext;

+class PositionWithAffinity;

class RenderBlock;

class RenderView;

@@ -47,6 +48,7 @@ protected:

void invalidateCaretRect(Node*, bool caretRectChanged = false);

void clearCaretRect();

+ bool updateCaretRect(Document*, const PositionWithAffinity& caretPosition);

tkent 2014/07/29 09:30:20 Please add a comment about differences between two

yoichio 2014/07/29 10:32:46 Done.

bool updateCaretRect(Document*, const VisiblePosition& caretPosition);

IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&) const;

bool shouldRepaintCaret(const RenderView*, bool isContentEditable) const;

« no previous file with comments | « no previous file | Source/core/editing/Caret.cpp » ('j') | Source/core/editing/VisibleUnits.h » ('J')