Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 429453003: Create a visitor which can allow using both a trace... visitor and the (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Use_1350_byte_packet_71837432
Project:
chromium
Visibility:
Public.

Description

Create a visitor which can allow using both a trace... visitor and the existing stats visitor. Changed QuicConnection's QuicConnectionDebugVisitor to a scoped_ptr. Merge internal change: 71863508 R=rch@chromium.org

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M net/quic/quic_client_session.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_client_session.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 19 chunks +18 lines, -19 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-07-29 00:42:31 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/429453003/diff/1/net/quic/quic_client_session.h File net/quic/quic_client_session.h (right): https://codereview.chromium.org/429453003/diff/1/net/quic/quic_client_session.h#newcode239 net/quic/quic_client_session.h:239: QuicConnectionLogger* logger_; I take it this is no ...
6 years, 4 months ago (2014-07-29 19:16:51 UTC) #2
ramant (doing other things)
Thanks Ryan. Made the changes we had talked offline. https://codereview.chromium.org/429453003/diff/1/net/quic/quic_client_session.h File net/quic/quic_client_session.h (right): https://codereview.chromium.org/429453003/diff/1/net/quic/quic_client_session.h#newcode239 net/quic/quic_client_session.h:239: ...
6 years, 4 months ago (2014-07-29 21:28:58 UTC) #3
Ryan Hamilton
6 years, 4 months ago (2014-07-29 22:04:21 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698