Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/source_file.h

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clang warning Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/function_get_target_outputs.cc ('K') | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/source_file.cc » ('j') | tools/gn/substitution_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/source_file.h
diff --git a/tools/gn/source_file.h b/tools/gn/source_file.h
index 83ce2b59d50bc182e205e1d0bac9fd5d9ed38c5e..8e53de31123d8b8708f8d9a2232bf89964755ca8 100644
--- a/tools/gn/source_file.h
+++ b/tools/gn/source_file.h
@@ -18,11 +18,17 @@ class SourceDir;
// ends in one.
class SourceFile {
public:
+ enum SwapIn { SWAP_IN };
+
SourceFile();
// Takes a known absolute source file. Always begins in a slash.
explicit SourceFile(const base::StringPiece& p);
+ // Constructs from the given string by swapping in the contents of the given
+ // value. The value will be the empty string after this call.
+ explicit SourceFile(SwapIn, std::string* value);
scottmg 2014/08/05 22:30:32 no explicit necessary
+
~SourceFile();
bool is_null() const { return value_.empty(); }
« tools/gn/function_get_target_outputs.cc ('K') | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/source_file.cc » ('j') | tools/gn/substitution_list.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698