Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/source_file.cc

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clang warning Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/source_file.h ('K') | « tools/gn/source_file.h ('k') | tools/gn/substitution_list.h » ('j') | tools/gn/substitution_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/source_file.cc
diff --git a/tools/gn/source_file.cc b/tools/gn/source_file.cc
index f9ca7d0885b85bf3c969d5d089ffceb988e18984..7744850d5c5966ea048f529641b5683ba5ebbe88 100644
--- a/tools/gn/source_file.cc
+++ b/tools/gn/source_file.cc
@@ -19,6 +19,13 @@ SourceFile::SourceFile(const base::StringPiece& p)
DCHECK(!EndsWithSlash(value_));
}
+SourceFile::SourceFile(SwapIn, std::string* value) {
+ value_.swap(*value);
+ DCHECK(!value_.empty());
+ DCHECK(value_[0] == '/');
+ DCHECK(!EndsWithSlash(value_));
+}
+
SourceFile::~SourceFile() {
}
« tools/gn/source_file.h ('K') | « tools/gn/source_file.h ('k') | tools/gn/substitution_list.h » ('j') | tools/gn/substitution_list.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698