tools/gn/gn.gyp - Issue 429423002: Refactor GN source expansions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/gn.gyp

Issue 429423002: Refactor GN source expansions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clang warning Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/gn.gyp

diff --git a/tools/gn/gn.gyp b/tools/gn/gn.gyp

index c94c8e27bef5049d813afa91209010f5281d4c27..921317d9f598aabf29bd5f53ff4a2c7354a19ffb 100644

--- a/tools/gn/gn.gyp

+++ b/tools/gn/gn.gyp

@@ -48,8 +48,6 @@

'err.h',

'escape.cc',

'escape.h',

- 'file_template.cc',

- 'file_template.h',

'filesystem_utils.cc',

'filesystem_utils.h',

'functions_target.cc',

@@ -136,6 +134,14 @@

'standard_out.h',

'string_utils.cc',

'string_utils.h',

+ 'substitution_list.cc',

+ 'substitution_list.h',

+ 'substitution_pattern.cc',

+ 'substitution_pattern.h',

+ 'substitution_type.cc',

+ 'substitution_type.h',

+ 'substitution_writer.cc',

+ 'substitution_writer.h',

'target.cc',

'target.h',

'target_generator.cc',

@@ -181,7 +187,6 @@

'config_values_extractors_unittest.cc',

'escape_unittest.cc',

'filesystem_utils_unittest.cc',

- 'file_template_unittest.cc',

'function_foreach_unittest.cc',

'function_get_label_info_unittest.cc',

'function_get_path_info_unittest.cc',

@@ -209,6 +214,8 @@

'scope_unittest.cc',

'source_dir_unittest.cc',

'string_utils_unittest.cc',

+ 'substitution_pattern_unittest.cc',

+ 'substitution_writer_unittest.cc',

'target_generator_unittest.cc',

'target_unittest.cc',

'test_with_scope.cc',

« tools/gn/function_get_target_outputs.cc ('K') | « tools/gn/function_write_file.cc ('k') | tools/gn/ninja_action_target_writer.h » ('j') | tools/gn/source_file.h » ('J')