Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 429413003: Revert of Cache the current WebPreferences on RenderViewHostImpl. (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Cache the current WebPreferences on RenderViewHostImpl. (https://codereview.chromium.org/373323003/) Reason for revert: Causes DOA on 38-dev. https://code.google.com/p/chromium/issues/detail?id=398751 Original issue's description: > Cache the current WebPreferences on RenderViewHostImpl. > > This makes lookups of a WebPreferences field fast. > In order do this, add code to listen to all preferences updates in order to recompute the cache. > > BUG=390799 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284592 TBR=jam, michaelbai, chrishtr, avi NOTREECHECKS=true NOTRY=true BUG=390799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -74 lines) Patch
M android_webview/native/aw_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 7 chunks +10 lines, -20 lines 0 comments Download
M content/browser/android/content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/public/test/web_contents_tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
erikchen
Created Revert of Cache the current WebPreferences on RenderViewHostImpl.
6 years, 4 months ago (2014-07-31 02:18:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/429413003/1
6 years, 4 months ago (2014-07-31 02:20:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 02:20:31 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 02:20:32 UTC) #4
Avi (use Gerrit)
lgtm
6 years, 4 months ago (2014-07-31 02:21:57 UTC) #5
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 4 months ago (2014-07-31 19:51:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/429413003/1
6 years, 4 months ago (2014-07-31 19:54:49 UTC) #7
commit-bot: I haz the power
Change committed as 286876
6 years, 4 months ago (2014-07-31 20:00:37 UTC) #8
chrishtr
Oh this just committed now? That's sad. I fixed the underlying inspector prefs issue an ...
6 years, 4 months ago (2014-07-31 20:03:15 UTC) #9
erikchen
6 years, 4 months ago (2014-08-01 22:36:19 UTC) #10
Message was sent while issue was closed.
The revert got pushed to dev channel shortly after the bug was diagnosed. This
revert is for top of tree/canary.

Btw, I looked at your fix for the problem (Delete inspector settings in
WebViewImpl). I agree that deleting the inspector settings will fix this
instance of the problem, but how are you ensuring that similar problems won't
happen in the future? I didn't look too much into it, but it looked like we got
into an infinite loop with observing changes to the pref file & changing the
pref file. Given the severity of the problem, it would be good to see tests that
catch this sort of problem, or a restructuring of the logic to prevent this sort
of problem from occurring.

Powered by Google App Engine
This is Rietveld 408576698