Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 429413003: Revert of Cache the current WebPreferences on RenderViewHostImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 virtual SiteInstance* GetSiteInstance() const OVERRIDE; 197 virtual SiteInstance* GetSiteInstance() const OVERRIDE;
198 virtual bool IsRenderViewLive() const OVERRIDE; 198 virtual bool IsRenderViewLive() const OVERRIDE;
199 virtual void NotifyMoveOrResizeStarted() OVERRIDE; 199 virtual void NotifyMoveOrResizeStarted() OVERRIDE;
200 virtual void SetWebUIProperty(const std::string& name, 200 virtual void SetWebUIProperty(const std::string& name,
201 const std::string& value) OVERRIDE; 201 const std::string& value) OVERRIDE;
202 virtual void Zoom(PageZoom zoom) OVERRIDE; 202 virtual void Zoom(PageZoom zoom) OVERRIDE;
203 virtual void SyncRendererPrefs() OVERRIDE; 203 virtual void SyncRendererPrefs() OVERRIDE;
204 virtual WebPreferences GetWebkitPreferences() OVERRIDE; 204 virtual WebPreferences GetWebkitPreferences() OVERRIDE;
205 virtual void UpdateWebkitPreferences( 205 virtual void UpdateWebkitPreferences(
206 const WebPreferences& prefs) OVERRIDE; 206 const WebPreferences& prefs) OVERRIDE;
207 virtual void OnWebkitPreferencesChanged() OVERRIDE;
208 virtual void GetAudioOutputControllers( 207 virtual void GetAudioOutputControllers(
209 const GetAudioOutputControllersCallback& callback) const OVERRIDE; 208 const GetAudioOutputControllersCallback& callback) const OVERRIDE;
210 virtual void SelectWordAroundCaret() OVERRIDE; 209 virtual void SelectWordAroundCaret() OVERRIDE;
211 210
212 #if defined(OS_ANDROID) 211 #if defined(OS_ANDROID)
213 virtual void ActivateNearestFindResult(int request_id, 212 virtual void ActivateNearestFindResult(int request_id,
214 float x, 213 float x,
215 float y) OVERRIDE; 214 float y) OVERRIDE;
216 virtual void RequestFindMatchRects(int current_version) OVERRIDE; 215 virtual void RequestFindMatchRects(int current_version) OVERRIDE;
217 #endif 216 #endif
(...skipping 17 matching lines...) Expand all
235 int opener_route_id, 234 int opener_route_id,
236 int proxy_route_id, 235 int proxy_route_id,
237 int32 max_page_id, 236 int32 max_page_id,
238 bool window_was_created_with_opener); 237 bool window_was_created_with_opener);
239 238
240 base::TerminationStatus render_view_termination_status() const { 239 base::TerminationStatus render_view_termination_status() const {
241 return render_view_termination_status_; 240 return render_view_termination_status_;
242 } 241 }
243 242
244 // Returns the content specific prefs for this RenderViewHost. 243 // Returns the content specific prefs for this RenderViewHost.
245 WebPreferences ComputeWebkitPrefs(const GURL& url); 244 WebPreferences GetWebkitPrefs(const GURL& url);
246 245
247 // Sends the given navigation message. Use this rather than sending it 246 // Sends the given navigation message. Use this rather than sending it
248 // yourself since this does the internal bookkeeping described below. This 247 // yourself since this does the internal bookkeeping described below. This
249 // function takes ownership of the provided message pointer. 248 // function takes ownership of the provided message pointer.
250 // 249 //
251 // If a cross-site request is in progress, we may be suspended while waiting 250 // If a cross-site request is in progress, we may be suspended while waiting
252 // for the onbeforeunload handler, so this function might buffer the message 251 // for the onbeforeunload handler, so this function might buffer the message
253 // rather than sending it. 252 // rather than sending it.
254 // TODO(nasko): Remove this method once all callers are converted to use 253 // TODO(nasko): Remove this method once all callers are converted to use
255 // RenderFrameHostImpl. 254 // RenderFrameHostImpl.
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 // Called after receiving the SwapOutACK when the RVH is in state pending 600 // Called after receiving the SwapOutACK when the RVH is in state pending
602 // shutdown. Also called if the unload timer times out. 601 // shutdown. Also called if the unload timer times out.
603 // TODO(nasko): Move to RenderFrameHost, as this is per-frame state. 602 // TODO(nasko): Move to RenderFrameHost, as this is per-frame state.
604 base::Closure pending_shutdown_on_swap_out_; 603 base::Closure pending_shutdown_on_swap_out_;
605 604
606 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 605 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
607 606
608 // True if the current focused element is editable. 607 // True if the current focused element is editable.
609 bool is_focused_element_editable_; 608 bool is_focused_element_editable_;
610 609
611 // This is updated every time UpdateWebkitPreferences is called. That method
612 // is in turn called when any of the settings change that the WebPreferences
613 // values depend on.
614 scoped_ptr<WebPreferences> web_preferences_;
615
616 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 610 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
617 }; 611 };
618 612
619 #if defined(COMPILER_MSVC) 613 #if defined(COMPILER_MSVC)
620 #pragma warning(pop) 614 #pragma warning(pop)
621 #endif 615 #endif
622 616
623 } // namespace content 617 } // namespace content
624 618
625 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 619 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698