Chromium Code Reviews
Help | Chromium Project | Sign in
(746)

Issue 4291001: Convert implicit scoped_refptr constructor calls to explicit ones, part 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Nico
Modified:
2 years, 11 months ago
CC:
chromium-reviews_chromium.org, Victoria Kirst, stuartmorgan+watch_chromium.org, ncarter, fbarchard, Alpha, Erik does not do reviews, jam, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, timsteele, ben+cc_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, pam+watch_chromium.org, awong, scherkus, michaeln, Sergey Ulanov, idana, Aaron Boodman, dmac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert implicit scoped_refptr constructor calls to explicit ones, part 2

This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041
I then did quite a bit of manual editing to fix style issues.

BUG=28083
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64798

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : manual tweaks #

Patch Set 4 : presubmit etc #

Patch Set 5 : style tweaks #

Total comments: 4

Patch Set 6 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -213 lines) Lint Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments ? errors Download
M chrome/browser/extensions/extensions_service.cc View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M chrome/browser/extensions/extensions_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/browser/memory_purger.cc View 1 2 3 3 chunks +5 lines, -7 lines 0 comments 0 errors Download
M chrome/browser/printing/print_job_manager.cc View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments ? errors Download
M chrome/browser/sync/engine/process_commit_response_command_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments ? errors Download
M chrome/browser/sync/engine/verify_updates_command_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M chrome/renderer/render_view.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments ? errors Download
M chrome/test/automation/dom_element_proxy.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M ipc/ipc_channel_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M media/base/pipeline_impl.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M net/base/host_resolver_impl.cc View 1 2 3 4 3 chunks +10 lines, -6 lines 0 comments ? errors Download
M net/disk_cache/file_posix.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments ? errors Download
M net/disk_cache/in_flight_backend_io.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/disk_cache/in_flight_io.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M net/http/http_network_transaction.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/http/http_proxy_client_socket.cc View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M net/proxy/init_proxy_resolver.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments 0 errors Download
M net/proxy/multi_threaded_proxy_resolver.cc View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M net/proxy/proxy_bypass_rules.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments ? errors Download
M net/proxy/proxy_service.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments ? errors Download
M net/socket/client_socket_handle.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments ? errors Download
M net/socket/client_socket_pool_base.cc View 1 2 3 6 chunks +14 lines, -12 lines 0 comments ? errors Download
M net/socket/socks5_client_socket.cc View 1 2 3 3 chunks +18 lines, -10 lines 0 comments ? errors Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 9 chunks +16 lines, -11 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_libevent.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments ? errors Download
M net/socket/tcp_client_socket_pool.cc View 2 chunks +4 lines, -4 lines 0 comments 0 errors Download
M net/socket_stream/socket_stream.cc View 1 2 3 3 chunks +7 lines, -4 lines 0 comments ? errors Download
M net/spdy/spdy_http_stream.cc View 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M net/spdy/spdy_proxy_client_socket.cc View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments ? errors Download
M net/spdy/spdy_session.cc View 1 2 3 4 16 chunks +40 lines, -30 lines 0 comments ? errors Download
M net/spdy/spdy_session_pool.cc View 1 2 3 4 chunks +16 lines, -12 lines 0 comments ? errors Download
M net/spdy/spdy_stream.cc View 1 2 3 7 chunks +21 lines, -16 lines 0 comments ? errors Download
M net/url_request/url_request.cc View 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M net/websockets/websocket.cc View 3 chunks +3 lines, -3 lines 0 comments ? errors Download
M net/websockets/websocket_job.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments ? errors Download
M remoting/base/multiple_array_input_stream.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments ? errors Download
M remoting/base/tracer.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M remoting/protocol/jingle_chromotocol_server.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M remoting/protocol/message_decoder.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments ? errors Download
M remoting/protocol/protocol_test_client.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M webkit/appcache/appcache_storage_impl.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M webkit/appcache/mock_appcache_storage.cc View 1 2 3 2 chunks +8 lines, -4 lines 0 comments ? errors Download
M webkit/glue/plugins/pepper_file_chooser.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments ? errors Download
M webkit/glue/plugins/plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M webkit/glue/plugins/plugin_lib.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M webkit/glue/webmediaplayer_impl.cc View 1 2 3 1 chunk +8 lines, -4 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 5
Nico
3 years, 5 months ago #1
Nico
(This doesn't fix all instances for reasons I don't understand yet. But I figured this ...
3 years, 5 months ago #2
jamesr (out of office)
http://codereview.chromium.org/4291001/diff/12001/13001 File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/4291001/diff/12001/13001#newcode566 chrome/browser/automation/testing_automation_provider.cc:566: url, cookie_name, think this should be 4-space indented, no? ...
3 years, 5 months ago #3
Nico
All excellent points. http://codereview.chromium.org/4291001/diff/12001/13001 File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/4291001/diff/12001/13001#newcode566 chrome/browser/automation/testing_automation_provider.cc:566: url, cookie_name, On 2010/11/02 08:21:00, jamesr ...
3 years, 5 months ago #4
jamesr (out of office)
3 years, 5 months ago #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6