Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: net/socket/client_socket_handle.cc

Issue 4291001: Convert implicit scoped_refptr constructor calls to explicit ones, part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/build
Patch Set: comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/client_socket_handle.h" 5 #include "net/socket/client_socket_handle.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "net/base/net_errors.h" 10 #include "net/base/net_errors.h"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 break; 109 break;
110 } 110 }
111 111
112 // Broadcast that the socket has been acquired. 112 // Broadcast that the socket has been acquired.
113 // TODO(eroman): This logging is not complete, in particular set_socket() and 113 // TODO(eroman): This logging is not complete, in particular set_socket() and
114 // release() socket. It ends up working though, since those methods are being 114 // release() socket. It ends up working though, since those methods are being
115 // used to layer sockets (and the destination sources are the same). 115 // used to layer sockets (and the destination sources are the same).
116 DCHECK(socket_.get()); 116 DCHECK(socket_.get());
117 socket_->NetLog().BeginEvent( 117 socket_->NetLog().BeginEvent(
118 NetLog::TYPE_SOCKET_IN_USE, 118 NetLog::TYPE_SOCKET_IN_USE,
119 new NetLogSourceParameter("source_dependency", requesting_source_)); 119 make_scoped_refptr(new NetLogSourceParameter(
120 "source_dependency", requesting_source_)));
120 } 121 }
121 122
122 } // namespace net 123 } // namespace net
OLDNEW
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698