Make NSSInitSingleton::tpm_slot_ a ScopedPK11Slot.

Make NSSInitSingleton::tpm_slot_ a ScopedPK11Slot.

Based on https://codereview.chromium.org/426983002/ .

BUG=210525
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286593

[Ryan Sleevi, 2014-07-29 23:43:40]

Shuffling deckchairs, since we never destroy the singleton, but LGTM, mod one
question about possible UAF if we ever *did* clean up our messes.

https://codereview.chromium.org/428933002/diff/20001/crypto/nss_util.cc
File crypto/nss_util.cc (right):

https://codereview.chromium.org/428933002/diff/20001/crypto/nss_util.cc#newco...
crypto/nss_util.cc:389: tpm_slot_.reset(tpm_args->tpm_slot);
Would be great to either make this a scoped_ptr<> as well, or
PK11_ReferenceSlot. This one surprised me that it's "safe"

[pneubeck (no reviews), 2014-07-30 08:28:49]

https://codereview.chromium.org/428933002/diff/20001/crypto/nss_util.cc
File crypto/nss_util.cc (right):

https://codereview.chromium.org/428933002/diff/20001/crypto/nss_util.cc#newco...
crypto/nss_util.cc:389: tpm_slot_.reset(tpm_args->tpm_slot);
On 2014/07/29 23:43:40, Ryan Sleevi wrote:
> Would be great to either make this a scoped_ptr<> as well, or
> PK11_ReferenceSlot. This one surprised me that it's "safe"

Done.

[pneubeck (no reviews), 2014-07-30 12:59:57]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-07-30 13:00:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/428933002/40001

[commit-bot: I haz the power, 2014-07-30 14:50:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 21:03:52]

Change committed as 286593