Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 426983002: Make crypto::GetSystemNSSKeySlot asynchronous. (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Sleevi, mattm
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make crypto::GetSystemNSSKeySlot asynchronous. The system slot is set asynchronously, so the getting the system slot should happen asynchronously as well. BUG=210525 TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286493

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fixed typo in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M crypto/nss_util.cc View 2 chunks +21 lines, -9 lines 0 comments Download
M crypto/nss_util_internal.h View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pneubeck (no reviews)
6 years, 4 months ago (2014-07-29 15:52:47 UTC) #1
mattm
lgtm with nit https://codereview.chromium.org/426983002/diff/20001/crypto/nss_util_internal.h File crypto/nss_util_internal.h (right): https://codereview.chromium.org/426983002/diff/20001/crypto/nss_util_internal.h#newcode51 crypto/nss_util_internal.h:51: // laoded and |callback| is non-null, ...
6 years, 4 months ago (2014-07-29 23:16:46 UTC) #2
Ryan Sleevi
On 2014/07/29 23:16:46, mattm wrote: > lgtm with nit > > https://codereview.chromium.org/426983002/diff/20001/crypto/nss_util_internal.h > File crypto/nss_util_internal.h ...
6 years, 4 months ago (2014-07-29 23:41:48 UTC) #3
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-07-30 08:13:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/426983002/40001
6 years, 4 months ago (2014-07-30 08:15:38 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 11:39:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 11:43:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/924)
6 years, 4 months ago (2014-07-30 11:43:07 UTC) #8
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 4 months ago (2014-07-30 12:19:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/426983002/40001
6 years, 4 months ago (2014-07-30 12:20:58 UTC) #10
commit-bot: I haz the power
Change committed as 286493
6 years, 4 months ago (2014-07-30 12:24:33 UTC) #11
Ryan Sleevi
6 years, 4 months ago (2014-07-31 00:34:39 UTC) #12
Message was sent while issue was closed.
retroactive LGTM

Powered by Google App Engine
This is Rietveld 408576698