Refactor SPen related code into a separate class

Refactor SPen related code into a separate class

BUG=398169
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288363

[jdduke (slow), 2014-08-01 14:38:43]

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:121:
private static Boolean sIsSPenSupported;
You can remove this and the other associated static methods.

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1144:
public static boolean isSPenSupported(Context context) {
This and the below methods can be removed.

[Changwan Ryu, 2014-08-02 13:45:17]

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:121:
private static Boolean sIsSPenSupported;
On 2014/08/01 14:38:43, jdduke wrote:
> You can remove this and the other associated static methods.

I intentionally left this in order not to break chrome on android build.

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1144:
public static boolean isSPenSupported(Context context) {
On 2014/08/01 14:38:43, jdduke wrote:
> This and the below methods can be removed.

Ditto.

[Changwan Ryu, 2014-08-02 13:47:06]

On 2014/08/02 13:45:17, Changwan Ryu wrote:
>
https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> (right):
> 
>
https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:121:
> private static Boolean sIsSPenSupported;
> On 2014/08/01 14:38:43, jdduke wrote:
> > You can remove this and the other associated static methods.
> 
> I intentionally left this in order not to break chrome on android build.
I mean 3-way merge. Let me remove those in a follow-up commit.
> 
>
https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1144:
> public static boolean isSPenSupported(Context context) {
> On 2014/08/01 14:38:43, jdduke wrote:
> > This and the below methods can be removed.
> 
> Ditto.

[jdduke (slow), 2014-08-02 14:14:07]

lgtm

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1144:
public static boolean isSPenSupported(Context context) {
On 2014/08/02 13:45:17, Changwan Ryu wrote:
> On 2014/08/01 14:38:43, jdduke wrote:
> > This and the below methods can be removed.
> 
> Ditto.

Sounds good.

[jdduke (slow), 2014-08-04 21:20:21]

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/SPenSupport.java
(right):

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/SPenSupport.java:13:
* Support S-Pen event detection and conversion
Nit: Looks like you want a period after this comment.

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/SPenSupport.java:53:
* @return Event action after the conversion
Nit: Period after description.

[Changwan Ryu, 2014-08-08 12:17:15]

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/SPenSupport.java
(right):

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/SPenSupport.java:13:
* Support S-Pen event detection and conversion
On 2014/08/04 21:20:20, jdduke wrote:
> Nit: Looks like you want a period after this comment.

Done.

https://codereview.chromium.org/428883013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/SPenSupport.java:53:
* @return Event action after the conversion
On 2014/08/04 21:20:21, jdduke wrote:
> Nit: Period after description.

Done.

[Changwan Ryu, 2014-08-08 12:21:51]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2014-08-08 12:22:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/changwan@chromium.org/428883013/60001

[commit-bot: I haz the power, 2014-08-08 13:46:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 15:28:32]

Change committed as 288363