content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 428883013: Refactor SPen related code into a separate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 428883013: Refactor SPen related code into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 5f0f0fefcc5bfd439a086ea1baa684bafbb6b04a..7fb1b5484944e526c3314a716bcd5c286abe9a2b 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1202,8 +1202,8 @@ public class ContentViewCore

cancelRequestToScrollFocusedEditableNodeIntoView();

}

- if (isSPenSupported(mContext))

- eventAction = convertSPenEventAction(eventAction);

+ if (SPenSupport.isSPenSupported(mContext))

+ eventAction = SPenSupport.convertSPenEventAction(eventAction);

if (!isValidTouchEventActionForNative(eventAction)) return false;

if (mNativeContentViewCore == 0) return false;

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/SPenSupport.java » ('j') | no next file with comments »