Issue 428753002: Fix for ARM cross build with clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428753002: Fix for ARM cross build with clang. (Closed)

Created:
6 years, 4 months ago by Sam Clegg

Modified:
6 years, 4 months ago

Reviewers:
Mark Seaborn, Roland McGrath

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Fix for ARM cross build with clang. This fixes an error building nacl_bootstrap_raw: /usr/bin/ld.bfd: unrecognised emulation mode: armelf_linux_eabi With the clang build we don't set CXX so 'compiler' was defaulting to 'g++' which doesn't support armelf_linux_eabi. BUG= https://code.google.com/p/chromium/issues/detail?id=395832 R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13584

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/trusted/service_runtime/linux/nacl_bootstrap.gyp	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Sam Clegg

Split out from previous change: https://codereview.chromium.org/411803002/

6 years, 4 months ago (2014-07-28 21:33:24 UTC) #2

Sam Clegg

This is now the only blocker on getting the ARM builder back up and running ...

6 years, 4 months ago (2014-08-05 09:23:04 UTC) #3

Mark Seaborn

OK, LGTM, thanks. Please set BUG= to a full issue URL so that Bugdroid works.

6 years, 4 months ago (2014-08-05 17:31:06 UTC) #4

Sam Clegg

6 years, 4 months ago (2014-08-06 08:39:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 13584 (presubmit successful).