Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: public/web/WebSettings.h

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/Settings.in ('K') | « Source/web/WebSettingsImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebSettings.h
diff --git a/public/web/WebSettings.h b/public/web/WebSettings.h
index cf3cb1905fc915d2ad4910a42d3e07b5c5f238d6..fd14b69487b39d93fe6fb2d41c501359517b2129 100644
--- a/public/web/WebSettings.h
+++ b/public/web/WebSettings.h
@@ -52,6 +52,8 @@ public:
EditingBehaviorAndroid
};
+ virtual bool disallowFullscreenForNonMediaElements() const = 0;
philipj_slow 2014/07/30 12:11:18 In total there are now four functions to support t
Ignacio Solla 2014/07/30 14:40:00 See my other reply that explains why we need the t
philipj_slow 2014/07/30 15:47:17 I applied your patch locally and tried removing th
Ignacio Solla 2014/07/31 10:30:51 That's right, sorry. Removed now.
+ virtual bool fullscreenEnabled() const = 0;
virtual bool mainFrameResizesAreOrientationChanges() const = 0;
virtual bool shrinksViewportContentToFit() const = 0;
virtual bool scrollAnimatorEnabled() const = 0;
@@ -122,6 +124,7 @@ public:
virtual void setExperimentalWebGLEnabled(bool) = 0;
virtual void setFantasyFontFamily(const WebString&, UScriptCode = USCRIPT_COMMON) = 0;
virtual void setFixedFontFamily(const WebString&, UScriptCode = USCRIPT_COMMON) = 0;
+ virtual void setFullscreenEnabled(bool) = 0;
virtual void setHyperlinkAuditingEnabled(bool) = 0;
virtual void setIgnoreMainFrameOverflowHiddenQuirk(bool) = 0;
virtual void setImagesEnabled(bool) = 0;
« Source/core/frame/Settings.in ('K') | « Source/web/WebSettingsImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698