Webkit setting for embedders that do not support fullscreen.

public/web/WebSettings.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 34 matching lines @@
 // these functions have a 1:1 mapping with the methods in WebCore/page/Settings.h.
 class WebSettings {
 public:
     enum EditingBehavior {
         EditingBehaviorMac,
         EditingBehaviorWin,
         EditingBehaviorUnix,
         EditingBehaviorAndroid
     };
 
+    virtual bool disallowFullscreenForNonMediaElements() const = 0;

[philipj_slow, 2014/07/30 12:11:18]

In total there are now four functions to support this:
    virtual bool disallowFullscreenForNonMediaElements() const = 0;
    virtual bool fullscreenEnabled() const = 0;
    virtual void setDisallowFullscreenForNonMediaElements(bool) = 0;
    virtual void setFullscreenEnabled(bool) = 0;

Why two settings, and why are the first two getters needed at all? I feel like I
don't have the whole picture here...

[Ignacio Solla, 2014/07/30 14:40:00]

See my other reply that explains why we need the two settings.

We need the two getters so that we can access them from FullscreenElementStack?

[philipj_slow, 2014/07/30 15:47:17]

I applied your patch locally and tried removing this. It works because
FullscreenElementStack uses Settings, not WebSettings.

[Ignacio Solla, 2014/07/31 10:30:51]

That's right, sorry. Removed now.

+    virtual bool fullscreenEnabled() const = 0;
     virtual bool mainFrameResizesAreOrientationChanges() const = 0;
     virtual bool shrinksViewportContentToFit() const = 0;
     virtual bool scrollAnimatorEnabled() const = 0;
     virtual bool touchEditingEnabled() const = 0;
     virtual bool viewportEnabled() const = 0;
     virtual bool viewportMetaEnabled() const = 0;
     virtual void setAccelerated2dCanvasEnabled(bool) = 0;
     virtual void setAccelerated2dCanvasMSAASampleCount(int) = 0;
     virtual void setAcceleratedCompositingEnabled(bool) = 0;
     virtual void setAcceleratedCompositingForCanvasEnabled(bool) = 0;
@@ skipping 50 matching lines @@
     virtual void setDeviceSupportsTouch(bool) = 0;
     virtual void setDoubleTapToZoomEnabled(bool) = 0;
     virtual void setDownloadableBinaryFontsEnabled(bool) = 0;
     virtual void setEditingBehavior(EditingBehavior) = 0;
     virtual void setEnableScrollAnimator(bool) = 0;
     virtual void setEnableTouchAdjustment(bool) = 0;
     virtual void setRegionBasedColumnsEnabled(bool) = 0;
     virtual void setExperimentalWebGLEnabled(bool) = 0;
     virtual void setFantasyFontFamily(const WebString&, UScriptCode = USCRIPT_COMMON) = 0;
     virtual void setFixedFontFamily(const WebString&, UScriptCode = USCRIPT_COMMON) = 0;
+    virtual void setFullscreenEnabled(bool) = 0;
     virtual void setHyperlinkAuditingEnabled(bool) = 0;
     virtual void setIgnoreMainFrameOverflowHiddenQuirk(bool) = 0;
     virtual void setImagesEnabled(bool) = 0;
     virtual void setJavaEnabled(bool) = 0;
     virtual void setJavaScriptCanAccessClipboard(bool) = 0;
     virtual void setJavaScriptCanOpenWindowsAutomatically(bool) = 0;
     virtual void setJavaScriptEnabled(bool) = 0;
     virtual void setLayerSquashingEnabled(bool) = 0;
     virtual void setLoadsImagesAutomatically(bool) = 0;
     virtual void setLoadWithOverviewMode(bool) = 0;
@@ skipping 68 matching lines @@
     virtual void setWideViewportQuirkEnabled(bool) = 0;
     virtual void setXSSAuditorEnabled(bool) = 0;
 
 protected:
     ~WebSettings() { }
 };
 
 } // namespace blink
 
 #endif