Webkit setting for embedders that do not support fullscreen.

Source/core/dom/FullscreenElementStack.cpp

Index: Source/core/dom/FullscreenElementStack.cpp
diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp
index c5fc482260612002eba1cabbc9cfbfc5bb253c7c..e717ad34d7582c32120739434dcf9a03aa14c709 100644
--- a/Source/core/dom/FullscreenElementStack.cpp
+++ b/Source/core/dom/FullscreenElementStack.cpp
@@ -148,6 +148,10 @@ void FullscreenElementStack::documentWasDisposed()
 
 void FullscreenElementStack::requestFullScreenForElement(Element& element, RequestType requestType)
 {
+    if (!document()->frameHost()->chrome().client().fullscreenEnabled(&element)) {

[philipj_slow, 2014/07/29 11:22:53]

This needs to be in the do { } while(0) loop below to trigger the
fullscreenerror event.

I also think you should just add a setting in Settings.in, which will be
required for testing and should allow you to remove all code except here,
Settings and WebSettings(Impl).

[Ignacio Solla, 2014/07/29 18:05:58]

I have moved this inside the while loop as you recommended. Also note that this
change probably falls into the following category in the spec:
"There is a previously-established user preference, security risk, or platform
limitation."

I have also added settings for both fullscreenEnabled and
disallowFullscreenForNonMediaElements, and also tests. I have also removed all
the unnecessary code after this change.

+        return;
+    }
+
     // Ignore this request if the document is not in a live frame.
     if (!document()->isActive())
         return;
@@ -262,6 +266,7 @@ void FullscreenElementStack::requestFullScreenForElement(Element& element, Reque
         // 5. Return, and run the remaining steps asynchronously.
         // 6. Optionally, perform some animation.
         m_areKeysEnabledInFullScreen = requestType != PrefixedMozillaRequest && requestType != PrefixedVideoRequest;
+

[philipj_slow, 2014/07/29 11:22:53]

stray newline

[Ignacio Solla, 2014/07/29 18:05:58]

Done.

         document()->frameHost()->chrome().client().enterFullScreenForElement(&element);
 
         // 7. Optionally, display a message indicating how the user can exit displaying the context object fullscreen.