Webkit setting for embedders that do not support fullscreen.

Source/core/dom/FullscreenElementStack.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
@@ skipping 130 matching lines @@
 {
     // NOTE: the context dispose phase is not supported in oilpan. Please
     // consider using the detach phase instead.
     m_fullScreenElement = nullptr;
     m_fullScreenElementStack.clear();
 }
 #endif
 
 void FullscreenElementStack::requestFullScreenForElement(Element& element, RequestType requestType)
 {
+    if (!document()->frameHost()->chrome().client().fullscreenEnabled(&element)) {

[philipj_slow, 2014/07/29 11:22:53]

This needs to be in the do { } while(0) loop below to trigger the
fullscreenerror event.

I also think you should just add a setting in Settings.in, which will be
required for testing and should allow you to remove all code except here,
Settings and WebSettings(Impl).

[Ignacio Solla, 2014/07/29 18:05:58]

I have moved this inside the while loop as you recommended. Also note that this
change probably falls into the following category in the spec:
"There is a previously-established user preference, security risk, or platform
limitation."

I have also added settings for both fullscreenEnabled and
disallowFullscreenForNonMediaElements, and also tests. I have also removed all
the unnecessary code after this change.

+        return;
+    }
+
     // Ignore this request if the document is not in a live frame.
     if (!document()->isActive())
         return;
 
     // The Mozilla Full Screen API <https://wiki.mozilla.org/Gecko:FullScreenAPI> has different requirements
     // for full screen mode, and do not have the concept of a full screen element stack.
     bool inLegacyMozillaMode = requestType == PrefixedMozillaRequest || requestType == PrefixedMozillaAllowKeyboardInputRequest;
 
     do {
         // 1. If any of the following conditions are true, terminate these steps and queue a task to fire
@@ skipping 94 matching lines @@
                 enqueueChangeEvent(*currentDoc);
                 continue;
             }
 
             // 4. Otherwise, do nothing for this document. It stays the same.
         } while (++current != docs.end());
 
         // 5. Return, and run the remaining steps asynchronously.
         // 6. Optionally, perform some animation.
         m_areKeysEnabledInFullScreen = requestType != PrefixedMozillaRequest && requestType != PrefixedVideoRequest;
+

[philipj_slow, 2014/07/29 11:22:53]

stray newline

[Ignacio Solla, 2014/07/29 18:05:58]

Done.

         document()->frameHost()->chrome().client().enterFullScreenForElement(&element);
 
         // 7. Optionally, display a message indicating how the user can exit displaying the context object fullscreen.
         return;
     } while (0);
 
     enqueueErrorEvent(element);
 }
 
 void FullscreenElementStack::fullyExitFullscreen()
@@ skipping 297 matching lines @@
 
 void FullscreenElementStack::trace(Visitor* visitor)
 {
     visitor->trace(m_fullScreenElement);
     visitor->trace(m_fullScreenElementStack);
     visitor->trace(m_eventQueue);
     DocumentSupplement::trace(visitor);
 }
 
 } // namespace blink