Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Side by Side Diff: LayoutTests/fullscreen/full-screen-request-not-enabled.html

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments and nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <body>
falken 2014/07/31 14:53:10 ditto about <body>
Ignacio Solla 2014/08/01 10:02:44 Done.
2 <script src="full-screen-test.js"></script>
3 <video id="video" width="300"></video>
4 <div>Tests for the fullScreenEnabled setting which will be set to false
5 in those platforms where full screen is not supported.
6 <script>
7 if (window.internals) {
8 window.internals.settings.setFullScreenEnabled(false);
9
10 waitForEvent(document, 'webkitfullscreenchange', function() {
11 logResult("Entered full screen.", false);
falken 2014/07/31 14:53:10 Seems like these arguments are switched? function
Ignacio Solla 2014/08/01 10:02:44 Done.
12 endTest();
13 });
14 waitForEventAndEnd(document, 'webkitfullscreenerror');
15 runWithKeyDown(function(){document.getElementById('video').webkitRequest FullScreen()});
16 }
17 </script>
18
falken 2014/07/31 14:53:10 nit: extra line here
Ignacio Solla 2014/08/01 10:02:44 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698