LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments and nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt » ('j') | LayoutTests/fullscreen/full-screen-request-not-enabled.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <body>
	falken 2014/07/31 14:53:10 <body> is usually omitted in layout tests. If some <body> is usually omitted in layout tests. If somehow this is required, it should have a closing </body>. Ignacio Solla 2014/08/01 10:02:44 Done. Show quoted text On 2014/07/31 14:53:10, falken wrote: > <body> is usually omitted in layout tests. If somehow this is required, it > should have a closing </body>. Done.
	2 <script src="full-screen-test.js"></script>

	3 <span id="span" width="300"></span>

	4 <video id="video" width="300"></video>

	5 <div>Tests for the disallowFullscreenForNonMediaElements setting which will be s et

	6 in those platforms where fullscreen for non-media elements is not supported.

	7 <script>

	8 if (window.internals) {

	9 window.internals.settings.setDisallowFullscreenForNonMediaElements(true) ;

	10

	11 var testStep2 = function() {

	12 // Fullscreen for media elements is supported, video in this case.

	13 waitForEventAndEnd(document, 'webkitfullscreenchange');

	14 runWithKeyDown(function(){document.getElementById('video').webkitReq uestFullScreen()});

	15 };

	16

	17 // Fullscreen for non media elements is not supported.

	18 waitForEventOnce(document, 'webkitfullscreenerror', testStep2);

	19 runWithKeyDown(function(){document.getElementById('span').webkitRequestF ullScreen()})

	20 }

	21 </script>

	22

OLD	NEW