Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 428583004: Translate: Bug fix: Wrong way to check if the window is minimized (Closed)

Created:
6 years, 4 months ago by hajimehoshi
Modified:
6 years, 4 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Translate: Bug fix: Wrong way to check if the window is minimized Before this CL, to check if the window is minimized, !IsActive() was used. This function returns false when the bubble window is focused on Windows or Chrome OS. Therefore, the bubble was not updated when the bubble is already shown. This CL fixes this bug by replacing !IsActive() with IsMinimize() to check the state of Window properly. BUG=393136, 389014 (the original CL about the bug around minimized window) TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hajimehoshi
PTAL
6 years, 4 months ago (2014-08-01 09:11:52 UTC) #1
hajimehoshi
+msw
6 years, 4 months ago (2014-08-04 18:50:31 UTC) #2
msw
lgtm
6 years, 4 months ago (2014-08-04 19:00:21 UTC) #3
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 4 months ago (2014-08-04 19:02:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/428583004/1
6 years, 4 months ago (2014-08-04 19:03:58 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 23:00:14 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 04:16:10 UTC) #7
Message was sent while issue was closed.
Change committed as 287448

Powered by Google App Engine
This is Rietveld 408576698