chrome/browser/ui/views/frame/browser_view.cc - Issue 428583004: Translate: Bug fix: Wrong way to check if the window is minimized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 428583004: Translate: Bug fix: Wrong way to check if the window is minimized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 0116260850a6d33fb8bb7a6c85960f7519a22dd9..bcf02326df3ae7cd0bb1caf9e3722c873bd96ebe 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1174,7 +1174,7 @@ void BrowserView::ShowTranslateBubble(

chrome_translate_client->GetLanguageState();

language_state.SetTranslateEnabled(true);

- if (!IsActive())

+ if (IsMinimized())

return;

TranslateBubbleView::ShowBubble(

« no previous file with comments | « no previous file | no next file » | no next file with comments »