Chromium Code Reviews Chromium Code Reviews
Issue 428353004:
Convert two pixel tests, editing/deleting/smart-delete-00{3,4}.html to JS test. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/editing/deleting/smart-delete-003.html |
| diff --git a/LayoutTests/editing/deleting/smart-delete-003.html b/LayoutTests/editing/deleting/smart-delete-003.html |
| index 82ca37371fac968cda2a826fb65dc821849b92ad..ac47ba810ab5ce7595e7e835071b2ee0b5f1a8b0 100644 |
| --- a/LayoutTests/editing/deleting/smart-delete-003.html |
| +++ b/LayoutTests/editing/deleting/smart-delete-003.html |
| @@ -1,15 +1,27 @@ |
| +<!DOCTYPE html> |
| +<script src="../../resources/js-test.js"></script> |
| +<div id="container"> |
| +<p>To run it manually, double click on 'bar' and hit delete. You should see 'foo baz'.</p> |
| +<div id="sample" contenteditable="true">foo b<span id="target">a</span>r baz</div> |
| +</div> |
| <script> |
| -if (window.testRunner) |
| - testRunner.dumpEditingCallbacks(); |
| -</script> |
| -<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> |
| -<p>This tests deleting a selection created with a word granularity. To run it manually, double click on 'bar' and hit delete. You should see 'foo baz'.</p> |
| -<div id="div" contenteditable="true">foo b<span id="target">a</span>r baz</div> |
| - |
| -<script> |
| +description('This tests deleting a selection created with a word granularity.'); |
| +var sample = document.getElementById('sample'); |
| +var target = document.getElementById('target'); |
| if (window.testRunner) { |
| - var target = document.getElementById("target"); |
| - doubleClick(target.offsetLeft, target.offsetTop); |
| - testRunner.execCommand("DeleteBackward"); |
| + // We don't care about select word includes trailing space or not in this |
| + // test. mac/unix selects only words, but win select word and a space. |
| + internals.settings.setSelectTrailingWhitespaceEnabled(true); |
|
ojan
2014/08/01 01:02:32
Avoid using internals wherever possible. It makes
yosin_UTC9
2014/08/01 01:53:27
Done. This test is already use |eventSender|. So,
|
| + eventSender.mouseMoveTo(target.offsetLeft, target.offsetTop); |
| + eventSender.mouseDown(); |
| + eventSender.mouseUp(); |
| + eventSender.mouseDown(); |
| + eventSender.mouseUp(); |
| + testRunner.execCommand('DeleteBackward'); |
| + shouldBeEqualToString('sample.innerText', 'foo baz'); |
| + shouldBe('getSelection().rangeCount', '1'); |
| + shouldBe('getSelection().focusNode', 'sample.firstChild'); |
| + shouldBe('getSelection().focusOffset', '4'); |
| + document.getElementById('container').outerHTML = ''; |
|
ojan
2014/08/01 01:02:32
I'm not a huge fan of this pattern of clearing the
yosin_UTC9
2014/08/01 01:53:27
Done.
|
| } |
| </script> |
