LayoutTests/editing/deleting/smart-delete-003.html - Issue 428353004: Convert two pixel tests, editing/deleting/smart-delete-00{3,4}.html to JS test.

Side by Side Diff: LayoutTests/editing/deleting/smart-delete-003.html

Issue 428353004: Convert two pixel tests, editing/deleting/smart-delete-00{3,4}.html to JS test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2014-07-31T16:34:38 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <div id="container">

	4 <p>To run it manually, double click on 'bar' and hit delete. You should see 'fo o baz'.</p>

	5 <div id="sample" contenteditable="true">foo b<span id="target">a</span>r baz</di v>

	6 </div>

1 <script>	7 <script>

2 if (window.testRunner)	8 description('This tests deleting a selection created with a word granularity.');

3 testRunner.dumpEditingCallbacks();	9 var sample = document.getElementById('sample');

4 </script>	10 var target = document.getElementById('target');

5 <script src=../editing.js language="JavaScript" type="text/JavaScript" ></script >

6 <p>This tests deleting a selection created with a word granularity. To run it m anually, double click on 'bar' and hit delete. You should see 'foo baz'.</p>

7 <div id="div" contenteditable="true">foo b<span id="target">a</span>r baz</div>

8

9 <script>

10 if (window.testRunner) {	11 if (window.testRunner) {

11 var target = document.getElementById("target");	12 // We don't care about select word includes trailing space or not in this

12 doubleClick(target.offsetLeft, target.offsetTop);	13 // test. mac/unix selects only words, but win select word and a space.

13 testRunner.execCommand("DeleteBackward");	14 internals.settings.setSelectTrailingWhitespaceEnabled(true);
	ojan 2014/08/01 01:02:32 Avoid using internals wherever possible. It makes Avoid using internals wherever possible. It makes it so your test doesn't work in other browsers. Also, the whole point of this test is to test that the trailing space gets deleted or not correctly on mac (that's what "smart" delete is), so we do care. yosin_UTC9 2014/08/01 01:53:27 Done. This test is already use \|eventSender\|. So, Show quoted text On 2014/08/01 01:02:32, ojan-only-code-yellow-reviews wrote: > Avoid using internals wherever possible. It makes it so your test doesn't work > in other browsers. Done. This test is already use \|eventSender\|. So, this test doesn't work automatically on any browser. We should run this test in DRT. Show quoted text > > Also, the whole point of this test is to test that the trailing space gets > deleted or not correctly on mac (that's what "smart" delete is), so we do care. I changed this test to verify both including space and excluding space. I would like to find test failure for other platforms failure during development rather than asking trybot.
	15 eventSender.mouseMoveTo(target.offsetLeft, target.offsetTop);

	16 eventSender.mouseDown();

	17 eventSender.mouseUp();

	18 eventSender.mouseDown();

	19 eventSender.mouseUp();

	20 testRunner.execCommand('DeleteBackward');

	21 shouldBeEqualToString('sample.innerText', 'foo baz');

	22 shouldBe('getSelection().rangeCount', '1');

	23 shouldBe('getSelection().focusNode', 'sample.firstChild');

	24 shouldBe('getSelection().focusOffset', '4');

	25 document.getElementById('container').outerHTML = '';
	ojan 2014/08/01 01:02:32 I'm not a huge fan of this pattern of clearing the I'm not a huge fan of this pattern of clearing the content. It makes the test harder to debug when something goes wrong. It's OK to just dump the text into the expected result. yosin_UTC9 2014/08/01 01:53:27 Done. Show quoted text On 2014/08/01 01:02:32, ojan-only-code-yellow-reviews wrote: > I'm not a huge fan of this pattern of clearing the content. It makes the test > harder to debug when something goes wrong. It's OK to just dump the text into > the expected result. Done.
14 }	26 }

15 </script>	27 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/deleting/smart-delete-003-expected.txt » ('j') | no next file with comments »