Convert two pixel tests, editing/deleting/smart-delete-00{3,4}.html to JS test.

Convert two pixel tests, editing/deleting/smart-delete-00{3,4}.html to JS test.

This patch converts two pixel tests, editing/deleting/smart-delete-00{3,4}.html
to JS test, because these tests are no need to be pixel tests.

This patch is a preparation of fixing issue 358947.

BUG=n/a
TEST=no new test because of no behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179382

[yosin_UTC9, 2014-07-31 08:23:02]

Could you review this patch?
Thanks in advance.

Note: This patch blocks http://crrev.com/432633002 for committing.

[ojan, 2014-08-01 01:02:32]

https://codereview.chromium.org/428353004/diff/40001/LayoutTests/editing/dele...
File LayoutTests/editing/deleting/smart-delete-003.html (right):

https://codereview.chromium.org/428353004/diff/40001/LayoutTests/editing/dele...
LayoutTests/editing/deleting/smart-delete-003.html:14:
internals.settings.setSelectTrailingWhitespaceEnabled(true);
Avoid using internals wherever possible. It makes it so your test doesn't work
in other browsers.

Also, the whole point of this test is to test that the trailing space gets
deleted or not correctly on mac (that's what "smart" delete is), so we do care.

https://codereview.chromium.org/428353004/diff/40001/LayoutTests/editing/dele...
LayoutTests/editing/deleting/smart-delete-003.html:25:
document.getElementById('container').outerHTML = '';
I'm not a huge fan of this pattern of clearing the content. It makes the test
harder to debug when something goes wrong. It's OK to just dump the text into
the expected result.

[yosin_UTC9, 2014-08-01 01:53:27]

Updated to follow comments.
Waiting for trybots turn green...

https://codereview.chromium.org/428353004/diff/40001/LayoutTests/editing/dele...
File LayoutTests/editing/deleting/smart-delete-003.html (right):

https://codereview.chromium.org/428353004/diff/40001/LayoutTests/editing/dele...
LayoutTests/editing/deleting/smart-delete-003.html:14:
internals.settings.setSelectTrailingWhitespaceEnabled(true);
On 2014/08/01 01:02:32, ojan-only-code-yellow-reviews wrote:
> Avoid using internals wherever possible. It makes it so your test doesn't work
> in other browsers.
Done. This test is already use |eventSender|. So, this test doesn't work
automatically on any browser. We should run this test in DRT.

> 
> Also, the whole point of this test is to test that the trailing space gets
> deleted or not correctly on mac (that's what "smart" delete is), so we do
care.
I changed this test to verify both including space and excluding space. I would
like to find test failure for other platforms failure during development rather
than asking trybot.

https://codereview.chromium.org/428353004/diff/40001/LayoutTests/editing/dele...
LayoutTests/editing/deleting/smart-delete-003.html:25:
document.getElementById('container').outerHTML = '';
On 2014/08/01 01:02:32, ojan-only-code-yellow-reviews wrote:
> I'm not a huge fan of this pattern of clearing the content. It makes the test
> harder to debug when something goes wrong. It's OK to just dump the text into
> the expected result.
Done.

[ojan, 2014-08-01 02:14:00]

lgtm

[yosin_UTC9, 2014-08-01 03:39:42]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-08-01 03:40:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/428353004/60001

[commit-bot: I haz the power, 2014-08-01 04:17:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20016)

[commit-bot: I haz the power, 2014-08-01 04:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 04:57:37]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20027)

[yosin_UTC9, 2014-08-01 05:07:27]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-08-01 05:07:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/428353004/60001

[commit-bot: I haz the power, 2014-08-01 06:16:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20042)

[commit-bot: I haz the power, 2014-08-01 07:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 07:18:50]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20053)

[yosin_UTC9, 2014-08-01 09:12:37]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-08-01 09:13:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/428353004/60001

[commit-bot: I haz the power, 2014-08-01 09:47:29]

Change committed as 179382