Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 428353002: Subzero: Fix a signed/unsigned warning reported on the Mac. (Closed)

Created:
6 years, 4 months ago by Jim Stichnoth
Modified:
6 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Fix a signed/unsigned warning reported on the Mac. Also cleans up some unneeded table size const static variables. BUG= https://codereview.chromium.org/296053008/ R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5acafbc

Patch Set 1 #

Patch Set 2 : Clean up some unneeded table size const static variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M src/IceInstX8632.cpp View 1 7 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jim Stichnoth
6 years, 4 months ago (2014-07-30 22:12:58 UTC) #1
jvoung (off chromium)
lgtm
6 years, 4 months ago (2014-07-30 22:36:54 UTC) #2
Jim Stichnoth
6 years, 4 months ago (2014-07-30 22:37:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r5acafbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698