Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/IceInstX8632.cpp

Issue 428353002: Subzero: Fix a signed/unsigned warning reported on the Mac. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Patch Set: Clean up some unneeded table size const static variables Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstX8632.cpp
diff --git a/src/IceInstX8632.cpp b/src/IceInstX8632.cpp
index 14e95031d8d7b20f85dcaafeef226786e31143fb..c30c9f55ee1f451a58588cefe0f64050036204bb 100644
--- a/src/IceInstX8632.cpp
+++ b/src/IceInstX8632.cpp
@@ -33,8 +33,6 @@ const struct InstX8632BrAttributes_ {
ICEINSTX8632BR_TABLE
#undef X
};
-const size_t InstX8632BrAttributesSize =
- llvm::array_lengthof(InstX8632BrAttributes);
const struct InstX8632CmppsAttributes_ {
const char *EmitString;
@@ -45,8 +43,6 @@ const struct InstX8632CmppsAttributes_ {
ICEINSTX8632CMPPS_TABLE
#undef X
};
-const size_t InstX8632CmppsAttributesSize =
- llvm::array_lengthof(InstX8632CmppsAttributes);
const struct TypeX8632Attributes_ {
const char *CvtString; // i (integer), s (single FP), d (double FP)
@@ -60,16 +56,12 @@ const struct TypeX8632Attributes_ {
ICETYPEX8632_TABLE
#undef X
};
-const size_t TypeX8632AttributesSize =
- llvm::array_lengthof(TypeX8632Attributes);
const char *InstX8632SegmentRegNames[] = {
#define X(val, name) name,
SEG_REGX8632_TABLE
#undef X
};
-const size_t InstX8632SegmentRegNamesSize =
- llvm::array_lengthof(InstX8632SegmentRegNames);
} // end of anonymous namespace
@@ -766,7 +758,7 @@ void InstX8632Cmov::dump(const Cfg *Func) const {
void InstX8632Cmpps::emit(const Cfg *Func) const {
Ostream &Str = Func->getContext()->getStrEmit();
assert(getSrcSize() == 2);
- assert(Condition < InstX8632CmppsAttributesSize);
+ assert(Condition < Cmpps_Invalid);
Str << "\t";
Str << "cmp" << InstX8632CmppsAttributes[Condition].EmitString << "ps"
<< "\t";
@@ -778,7 +770,7 @@ void InstX8632Cmpps::emit(const Cfg *Func) const {
void InstX8632Cmpps::dump(const Cfg *Func) const {
Ostream &Str = Func->getContext()->getStrDump();
- assert(Condition < InstX8632CmppsAttributesSize);
+ assert(Condition < Cmpps_Invalid);
dumpDest(Func);
Str << " = cmp" << InstX8632CmppsAttributes[Condition].EmitString << "ps"
<< "\t";
@@ -1360,8 +1352,7 @@ void OperandX8632Mem::emit(const Cfg *Func) const {
Ostream &Str = Func->getContext()->getStrEmit();
Str << TypeX8632Attributes[getType()].WidthString << " ";
if (SegmentReg != DefaultSegment) {
- assert(SegmentReg >= 0 &&
- static_cast<size_t>(SegmentReg) < InstX8632SegmentRegNamesSize);
+ assert(SegmentReg >= 0 && SegmentReg < SegReg_NUM);
Str << InstX8632SegmentRegNames[SegmentReg] << ":";
}
// TODO: The following is an almost verbatim paste of dump().
@@ -1404,8 +1395,7 @@ void OperandX8632Mem::emit(const Cfg *Func) const {
void OperandX8632Mem::dump(const Cfg *Func) const {
Ostream &Str = Func->getContext()->getStrDump();
if (SegmentReg != DefaultSegment) {
- assert(SegmentReg >= 0 &&
- static_cast<size_t>(SegmentReg) < InstX8632SegmentRegNamesSize);
+ assert(SegmentReg >= 0 && SegmentReg < SegReg_NUM);
Str << InstX8632SegmentRegNames[SegmentReg] << ":";
}
bool Dumped = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698