QUIC - enable persisting QuicServerInfo to disk cache. Deleted unused

QUIC - enable persisting QuicServerInfo to disk cache by default.

Deleted unused enable_quic_persist_server_info from params.

This change should improve success rate of zero RTT for QUIC.

R=rch@chromium.org, mmenke@chromium.org

Changes from this were merged into https://codereview.chromium.org/420313005/ (during move, fresh checkout, git cl patch, git rebase).

[wtc, 2014-07-31 02:05:44]

Patch set 1 LGTM.

[mmenke, 2014-07-31 14:59:49]

On 2014/07/31 02:05:44, wtc wrote:
> Patch set 1 LGTM.

Any potential reason to want to see this value when loading data from older
net-internals dumps?  If so, may want to keep around the display in the HTML
file, though adding support for the case where it's missing.

[mmenke, 2014-07-31 15:03:26]

On 2014/07/31 14:59:49, mmenke wrote:
> On 2014/07/31 02:05:44, wtc wrote:
> > Patch set 1 LGTM.
> 
> Any potential reason to want to see this value when loading data from older
> net-internals dumps?  If so, may want to keep around the display in the HTML
> file, though adding support for the case where it's missing.

Should add this is something we often do for net-internals - keep support for
displaying old-formatted data, until after the version with the (slightly) new
data format has hit stable.

There's also the opposite issue - loading new net-internals dumps in older
versions of net-internals.  Not sure what will be displayed with the CL as is -
undefined or false, I believe, or maybe nothing.

Maybe be simplest to continue including the field in the dictionary, and make
quic_view also just hide the entire field when it's not defined, and then remove
it from those in 3 or 4 months.  Or it could be a non-issue, and this is fine. 
This change certainly won't completely break cross-version net-internals dump
compatibility.

[ramant (doing other things), 2014-07-31 17:01:12]

On 2014/07/31 14:59:49, mmenke wrote:
> On 2014/07/31 02:05:44, wtc wrote:
> > Patch set 1 LGTM.
> 
> Any potential reason to want to see this value when loading data from older
> net-internals dumps? 

It has been true (in stable, beta) or false (since the below change).

https://codereview.chromium.org/346043002/diff/220001/chrome/browser/io_threa...
(line#1158)

Soon we will be checking in the following CL that sets it to true in dev and
beta.

https://codereview.chromium.org/428383002

IMO, we don't need to see this data. This data tells if we are getting 0RTT (1st
time when we load server config from disk cache). IMO, it is simpler to delete
this code.

> If so, may want to keep around the display in the HTML
> file, though adding support for the case where it's missing.

[mmenke, 2014-07-31 17:36:16]

On 2014/07/31 17:01:12, ramant wrote:
> On 2014/07/31 14:59:49, mmenke wrote:
> > On 2014/07/31 02:05:44, wtc wrote:
> > > Patch set 1 LGTM.
> > 
> > Any potential reason to want to see this value when loading data from older
> > net-internals dumps? 
> 
> It has been true (in stable, beta) or false (since the below change).
> 
>
https://codereview.chromium.org/346043002/diff/220001/chrome/browser/io_threa...
> (line#1158)
> 
> Soon we will be checking in the following CL that sets it to true in dev and
> beta.
> 
> https://codereview.chromium.org/428383002
> 
> IMO, we don't need to see this data. This data tells if we are getting 0RTT
(1st
> time when we load server config from disk cache). IMO, it is simpler to delete
> this code.
> 
> > If so, may want to keep around the display in the HTML
> > file, though adding support for the case where it's missing.

Ok, then LGTM!

[ramant (doing other things), 2014-07-31 17:38:23]

On 2014/07/31 17:36:16, mmenke wrote:
> On 2014/07/31 17:01:12, ramant wrote:
> > On 2014/07/31 14:59:49, mmenke wrote:
> > > On 2014/07/31 02:05:44, wtc wrote:
> > > > Patch set 1 LGTM.
> > > 
> > > Any potential reason to want to see this value when loading data from
older
> > > net-internals dumps? 
> > 
> > It has been true (in stable, beta) or false (since the below change).
> > 
> >
>
https://codereview.chromium.org/346043002/diff/220001/chrome/browser/io_threa...
> > (line#1158)
> > 
> > Soon we will be checking in the following CL that sets it to true in dev and
> > beta.
> > 
> > https://codereview.chromium.org/428383002
> > 
> > IMO, we don't need to see this data. This data tells if we are getting 0RTT
> (1st
> > time when we load server config from disk cache). IMO, it is simpler to
delete
> > this code.
> > 
> > > If so, may want to keep around the display in the HTML
> > > file, though adding support for the case where it's missing.
> 
> Ok, then LGTM!

Thanks mmenke. Will commit this change tomorrow after CL 
https://codereview.chromium.org/428383002 is deployed in Canary in tomorrow's
canary build.

[ramant (doing other things), 2014-08-01 19:36:48]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-01 19:39:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/428253003/1

[ramant (doing other things), 2014-08-01 21:05:54]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-01 21:07:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/428253003/20001

[commit-bot: I haz the power, 2014-08-02 07:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-02 07:34:39]

Failed to apply patch for chrome/browser/resources/net_internals/quic_view.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/net_internals/quic_view.html
  Hunk #1 FAILED at 3.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/net_internals/quic_view.html.rej

Patch:       chrome/browser/resources/net_internals/quic_view.html
Index: chrome/browser/resources/net_internals/quic_view.html
diff --git a/chrome/browser/resources/net_internals/quic_view.html
b/chrome/browser/resources/net_internals/quic_view.html
index
7d6f4ef4add5755b865155882f8452d038648d51..1759e04470b27fbf93fc6d550fa4d8b923be6702
100644
--- a/chrome/browser/resources/net_internals/quic_view.html
+++ b/chrome/browser/resources/net_internals/quic_view.html
@@ -3,7 +3,6 @@
     <li>QUIC Enabled: <span jscontent="!!quic_enabled"></span></li>
     <li>Origin To Force QUIC On: <span
jscontent="origin_to_force_quic_on"></span></li>
     <li>Packet Pacing Enabled: <span
jscontent="!!enable_quic_pacing"></span></li>
-    <li>Persist Server Config Information Enabled: <span
jscontent="!!enable_quic_persist_server_info"></span></li>
     <li>Consistent Port Selection Enabled: <span
jscontent="!!enable_quic_port_selection"></span></li>
   </ul>

[wtc, 2014-08-04 22:57:15]

Patch set 2 LGTM.