Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 428383002: QUIC - enable persisting of QUICServerInfo (server config) to disk (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

QUIC - enable persisting of QUICServerInfo (server config) to disk cache. R=jar@chromium.org, rch@chromium.org BUG=399118 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286760

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/http/http_network_session.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-07-31 00:15:55 UTC) #1
ramant (doing other things)
Hi Ryan, Jim suggested if we could smallest possible change to enable persisting QUIC server ...
6 years, 4 months ago (2014-07-31 00:17:10 UTC) #2
jar (doing other things)
lgtm
6 years, 4 months ago (2014-07-31 00:19:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/428383002/1
6 years, 4 months ago (2014-07-31 00:23:14 UTC) #4
rch (use chromium not google)
lgtm
6 years, 4 months ago (2014-07-31 00:37:37 UTC) #5
wtc
Patch set 1 LGTM. https://codereview.chromium.org/428383002/diff/1/net/http/http_network_session.cc File net/http/http_network_session.cc (right): https://codereview.chromium.org/428383002/diff/1/net/http/http_network_session.cc#newcode90 net/http/http_network_session.cc:90: enable_quic_persist_server_info(true), This is just a ...
6 years, 4 months ago (2014-07-31 00:58:02 UTC) #6
ramant (doing other things)
https://codereview.chromium.org/428383002/diff/1/net/http/http_network_session.cc File net/http/http_network_session.cc (right): https://codereview.chromium.org/428383002/diff/1/net/http/http_network_session.cc#newcode90 net/http/http_network_session.cc:90: enable_quic_persist_server_info(true), On 2014/07/31 00:58:02, wtc wrote: > > This ...
6 years, 4 months ago (2014-07-31 00:59:40 UTC) #7
jar (doing other things)
On 2014/07/31 00:58:02, wtc wrote: > Patch set 1 LGTM. > > https://codereview.chromium.org/428383002/diff/1/net/http/http_network_session.cc > File ...
6 years, 4 months ago (2014-07-31 03:16:02 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 12:27:10 UTC) #9
Message was sent while issue was closed.
Change committed as 286760

Powered by Google App Engine
This is Rietveld 408576698