Issue 428223002: Add delete operators for Instruction to make Visual C++ happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428223002: Add delete operators for Instruction to make Visual C++ happy. (Closed)

Created:
6 years, 4 months ago by Jarin

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne, danno, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add delete operators for Instruction to make Visual C++ happy. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22713

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/compiler/instruction.h	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jarin

Committed patchset #1 manually as r22713 (tree was closed).

6 years, 4 months ago (2014-07-30 14:36:21 UTC) #3

Sven Panne

6 years, 4 months ago (2014-07-31 06:45:51 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/428223002/diff/1/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/428223002/diff/1/src/compiler/instruction.h#n...
src/compiler/instruction.h:492: void operator delete(void*, size_t) {
UNREACHABLE(); }
I don't understand this commit: Why do we have to define new/delete here at all?
Instruction inherits from ZoneObject, which has exactly these definitions?
Probably we should have removed the new here instead of adding the deletes, I
gues...

Expand Messages | Collapse Messages