Add delete operators for Instruction to make Visual C++ happy.

src/compiler/instruction.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_INSTRUCTION_H_
 #define V8_COMPILER_INSTRUCTION_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 471 matching lines @@
   void set_pointer_map(PointerMap* map) {
     ASSERT(NeedsPointerMap());
     ASSERT_EQ(NULL, pointer_map_);
     pointer_map_ = map;
   }
 
   // Placement new operator so that we can smash instructions into
   // zone-allocated memory.
   void* operator new(size_t, void* location) { return location; }
 
+  void operator delete(void*, size_t) { UNREACHABLE(); }

[Sven Panne, 2014/07/31 06:45:51]

I don't understand this commit: Why do we have to define new/delete here at all?
Instruction inherits from ZoneObject, which has exactly these definitions?
Probably we should have removed the new here instead of adding the deletes, I
gues...

+  void operator delete(void* pointer, Zone* zone) { UNREACHABLE(); }
+
  protected:
   explicit Instruction(InstructionCode opcode)
       : opcode_(opcode),
         bit_field_(OutputCountField::encode(0) | InputCountField::encode(0) |
                    TempCountField::encode(0) | IsCallField::encode(false) |
                    IsControlField::encode(false)),
         pointer_map_(NULL) {}
 
   Instruction(InstructionCode opcode, size_t output_count,
               InstructionOperand** outputs, size_t input_count,
@@ skipping 332 matching lines @@
   DeoptimizationVector deoptimization_entries_;
 };
 
 OStream& operator<<(OStream& os, const InstructionSequence& code);
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_INSTRUCTION_H_