Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 428123002: Revert of components: Fix a couple of the TODO(GYP) todos. (Closed)

Created:
6 years, 4 months ago by SeRya
Modified:
6 years, 4 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, jochen (gone - plz use gerrit), awong, Dirk Pranke, jamesr, scottmg, blundell, Garrett Casto
Project:
chromium
Visibility:
Public.

Description

Revert of components: Fix a couple of the TODO(GYP) todos. (https://codereview.chromium.org/420113003/) Reason for revert: Likely caused build falure: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\components\invalidation\invalidation_test_support.invalidator_test_template.obj.rsp /c ..\..\components\invalidation\invalidator_test_template.cc /Foobj\components\invalidation\invalidation_test_support.invalidator_test_template.obj /Fdobj\components\invalidation_test_support.cc.pdb c:\b\build\slave\win\build\src\components\invalidation\invalidator_test_template.h(87) : fatalerror C1083: Cannot open include file: 'google/cacheinvalidation/types.pb.h': No such file or directory ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium/builders/Win/builds/22963/steps/compile/logs/stdio Original issue's description: > components: Fix a couple of the TODO(GYP) todos. > > BUG=None > TEST=gn gen out/Debug_gn + build the effected targets with ninja. > R=brettw@chromium.org > TBR=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286362 TBR=brettw@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M components/autofill/content/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/BUILD.gn View 3 chunks +5 lines, -4 lines 0 comments Download
M components/policy/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D third_party/fips181/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
SeRya
Created Revert of components: Fix a couple of the TODO(GYP) todos.
6 years, 4 months ago (2014-07-30 10:45:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/428123002/1
6 years, 4 months ago (2014-07-30 10:46:31 UTC) #2
commit-bot: I haz the power
Change committed as 286467
6 years, 4 months ago (2014-07-30 10:48:17 UTC) #3
tfarina
I think you made a mistake, the bot link is not a GN one and ...
6 years, 4 months ago (2014-07-30 13:26:21 UTC) #4
tfarina
I will reland!
6 years, 4 months ago (2014-07-30 13:29:14 UTC) #5
chromium-reviews
It could be mistake. It just looked more related than other changes for me. By ...
6 years, 4 months ago (2014-07-30 13:56:20 UTC) #6
brettw
6 years, 4 months ago (2014-07-30 22:24:33 UTC) #7
Message was sent while issue was closed.
yeah, this is not related to the GYP build, should reland.

Powered by Google App Engine
This is Rietveld 408576698