Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: components/invalidation/BUILD.gn

Issue 428123002: Revert of components: Fix a couple of the TODO(GYP) todos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/policy/core/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/BUILD.gn
diff --git a/components/invalidation/BUILD.gn b/components/invalidation/BUILD.gn
index 078ad640eefe5aa82c2c7637da937cb75b797f5f..fd6773a505d965b27741597c6254f28a626a8e68 100644
--- a/components/invalidation/BUILD.gn
+++ b/components/invalidation/BUILD.gn
@@ -81,11 +81,12 @@
deps = [
"//base",
- "//components/gcm_driver",
+ #"//components/gcm_driver", TODO(GYP)
+ "//google_apis",
"//components/keyed_service/core",
+ "//components/signin/core/browser:browser",
"//components/pref_registry",
- "//components/signin/core/browser",
- "//google_apis",
+ #"//components/signin/core/browser", TODO(GYP)
"//sync",
"//third_party/cacheinvalidation",
#'../jingle/jingle.gyp:notifier', TODO(GYP)
@@ -123,7 +124,6 @@
deps = [
"//base",
- "//components/gcm_driver:test_support",
"//components/keyed_service/core",
"//google_apis",
"//net",
@@ -133,5 +133,6 @@
#'../jingle/jingle.gyp:notifier', TODO(GYP)
#'../jingle/jingle.gyp:notifier_test_util', TODO(GYP)
#'../sync/sync.gyp:test_support_sync_notifier', TODO(GYP)
+ #'gcm_driver_test_support', TODO(GYP)
]
}
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/policy/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698