Change the default implementation of ExtensionFunction::HasPermission to use

Change the default implementation of ExtensionFunction::HasPermission to use
the real context type, not assume it's BLESSED_CONTEXT_TYPE (which has always
been wrong). This cleans up some other code.

BUG=391944
R=rockot@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287987

[not at google - send to devlin, 2014-08-06 17:35:30]

morning ping.

[not at google - send to devlin, 2014-08-06 17:36:01]

(not being impatient - but I like to be reminded in the morning, maybe you do
too)

[Ken Rockot(use gerrit already), 2014-08-06 21:44:45]

lgtm

I was a little wary of the guessing bit, but it seems like the worst that can
happen is you could incorrectly classify something as a
BLESSED_EXTENSION_CONTEXT, which is no worse than what happens now.

https://codereview.chromium.org/427983003/diff/20001/extensions/browser/proce...
File extensions/browser/process_map.cc (right):

https://codereview.chromium.org/427983003/diff/20001/extensions/browser/proce...
extensions/browser/process_map.cc:147: return (extension->is_hosted_app() &&
I think it would be better to make more explicit that BLESSED_EXTENSION_CONTEXT
is the default catch-all case:


if (extension->is_hosted_app() &&
    extension->location() != Manifest::COMPONENT) {
  return Feature::BLESSED_WEB_PAGE_CONTEXT;
}

return Feature::BLESSED_EXTENSION_CONTEXT;

[not at google - send to devlin, 2014-08-06 23:03:32]

https://codereview.chromium.org/427983003/diff/20001/extensions/browser/proce...
File extensions/browser/process_map.cc (right):

https://codereview.chromium.org/427983003/diff/20001/extensions/browser/proce...
extensions/browser/process_map.cc:147: return (extension->is_hosted_app() &&
On 2014/08/06 21:44:45, Ken Rockot wrote:
> I think it would be better to make more explicit that
BLESSED_EXTENSION_CONTEXT
> is the default catch-all case:
> 
> 
> if (extension->is_hosted_app() &&
>     extension->location() != Manifest::COMPONENT) {
>   return Feature::BLESSED_WEB_PAGE_CONTEXT;
> }
> 
> return Feature::BLESSED_EXTENSION_CONTEXT;

Done.

[not at google - send to devlin, 2014-08-06 23:03:42]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-08-06 23:05:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/427983003/60001

[commit-bot: I haz the power, 2014-08-07 07:27:24]

Change committed as 287987