Change the default implementation of ExtensionFunction::HasPermission to use

extensions/browser/process_map.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/process_map.h"
 
+#include "content/public/browser/child_process_security_policy.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/browser/process_map_factory.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/features/feature.h"
 
 namespace extensions {
 
 // Item
 struct ProcessMap::Item {
   Item() : process_id(0), site_instance_id(0) {
   }
 
   // Purposely implicit constructor needed on older gcc's. See:
   // http://codereview.chromium.org/8769022/
@@ skipping 94 matching lines @@
 std::set<std::string> ProcessMap::GetExtensionsInProcess(int process_id) const {
   std::set<std::string> result;
   for (ItemSet::const_iterator iter = items_.begin(); iter != items_.end();
        ++iter) {
     if (iter->process_id == process_id)
       result.insert(iter->extension_id);
   }
   return result;
 }
 
+Feature::Context ProcessMap::GuessContextType(const Extension* extension,
+                                              int process_id) const {
+  // WARNING: This logic must match Dispatcher::ClassifyJavaScriptContext, as
+  // much as possible.
+
+  if (content::ChildProcessSecurityPolicy::GetInstance()->HasWebUIBindings(
+          process_id)) {
+    return Feature::WEBUI_CONTEXT;
+  }
+
+  if (!extension) {
+    return Feature::WEB_PAGE_CONTEXT;
+  }
+
+  if (!Contains(extension->id(), process_id)) {
+    // This could equally be UNBLESSED_EXTENSION_CONTEXT, but we don't record
+    // which processes have extension frames in them.
+    // TODO(kalman): Investigate this.
+    return Feature::CONTENT_SCRIPT_CONTEXT;
+  }
+
+  return (extension->is_hosted_app() &&

[Ken Rockot(use gerrit already), 2014/08/06 21:44:45]

I think it would be better to make more explicit that BLESSED_EXTENSION_CONTEXT
is the default catch-all case:


if (extension->is_hosted_app() &&
    extension->location() != Manifest::COMPONENT) {
  return Feature::BLESSED_WEB_PAGE_CONTEXT;
}

return Feature::BLESSED_EXTENSION_CONTEXT;

[not at google - send to devlin, 2014/08/06 23:03:32]

Done.

+          extension->location() != Manifest::COMPONENT)
+             ? Feature::BLESSED_WEB_PAGE_CONTEXT
+             : Feature::BLESSED_EXTENSION_CONTEXT;
+}
+
 }  // namespace extensions