Port xxd.pl to xxd.py (Perl to Python)

Port xxd.pl to xxd.py (Perl to Python)

Per:
"Retiring build-time execution of Perl"
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fnWX8n6JrTg
xxd.pl is one of 3 remaining Perl scripts.

It is a very simple script, so this simply ports it directly to Python.

We should be able to merge this to make-file-arrays.py,
or do this a different way, but that's more involved,
so first just port to Python.

See also:
Refactor make-file-arrays.py to ease reuse
https://codereview.chromium.org/43083002/

BUG=347863
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160558

[Nils Barth (inactive), 2013-10-25 03:20:40]

Hi Adam,
Quick port of xxd.pl.
(And then there were 2...)

[abarth-chromium, 2013-10-25 04:01:53]

LGTM

Thanks!

[Nico, 2013-10-25 04:14:31]

lgtm, but two comments:

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
File Source/build/ConvertFileToHeaderWithCharacterArray.gypi (right):

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
Source/build/ConvertFileToHeaderWithCharacterArray.gypi:56: ],
Can this be

  'msvs_cygwin_shell': 0,

now?

https://codereview.chromium.org/42793005/diff/1/Source/build/scripts/xxd.py
File Source/build/scripts/xxd.py (right):

https://codereview.chromium.org/42793005/diff/1/Source/build/scripts/xxd.py#n...
Source/build/scripts/xxd.py:38: return args
Why not just `return sys.argv[1:]`? What does the optparse add?

[abarth-chromium, 2013-10-25 04:16:34]

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
File Source/build/ConvertFileToHeaderWithCharacterArray.gypi (right):

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
Source/build/ConvertFileToHeaderWithCharacterArray.gypi:56: ],
On 2013/10/25 04:14:31, Nico wrote:
> Can this be
> 
>   'msvs_cygwin_shell': 0,
> 
> now?

Do we need to explicitly set this value to zero?  I've just been deleting it
when moving scripts to Python.

https://codereview.chromium.org/42793005/diff/1/Source/core/core_derived_sour...
File Source/core/core_derived_sources.gyp (right):

https://codereview.chromium.org/42793005/diff/1/Source/core/core_derived_sour...
Source/core/core_derived_sources.gyp:131: 'msvs_cygwin_shell': 0,
Whatever we decide, we should be consistent here.

[Nico, 2013-10-25 04:18:15]

On Thu, Oct 24, 2013 at 9:16 PM, <abarth@chromium.org> wrote:

>
> https://codereview.chromium.**org/42793005/diff/1/Source/**build/**
>
ConvertFileToHeaderWithCharact**erArray.gypi<https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHeaderWithCharacterArray.gypi>
> File Source/build/**ConvertFileToHeaderWithCharact**erArray.gypi (right):
>
> https://codereview.chromium.**org/42793005/diff/1/Source/**build/**
>
ConvertFileToHeaderWithCharact**erArray.gypi#newcode56<https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHeaderWithCharacterArray.gypi#newcode56>
> Source/build/**ConvertFileToHeaderWithCharact**erArray.gypi:56: ],
> On 2013/10/25 04:14:31, Nico wrote:
>
>> Can this be
>>
>
>     'msvs_cygwin_shell': 0,
>>
>
>  now?
>>
>
> Do we need to explicitly set this value to zero?


As far as I know yes. +scottmg to back me up.


> I've just been deleting it when moving scripts to Python.
>
> https://codereview.chromium.**org/42793005/diff/1/Source/**
>
core/core_derived_sources.gyp<https://codereview.chromium.org/42793005/diff/1/Source/core/core_derived_sources.gyp>
> File Source/core/core_derived_**sources.gyp (right):
>
> https://codereview.chromium.**org/42793005/diff/1/Source/**
>
core/core_derived_sources.gyp#**newcode131<https://codereview.chromium.org/42793005/diff/1/Source/core/core_derived_sources.gyp#newcode131>
> Source/core/core_derived_**sources.gyp:131: 'msvs_cygwin_shell': 0,
> Whatever we decide, we should be consistent here.
>
>
https://codereview.chromium.**org/42793005/<https://codereview.chromium.org/4...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[abarth-chromium, 2013-10-25 04:24:31]

You seem to be right:

  def IsRuleRunUnderCygwin(self, rule):
    """Determine if an action should be run under cygwin. If the variable is
    unset, or set to 1 we use cygwin."""
    return int(rule.get('msvs_cygwin_shell',
                        self.spec.get('msvs_cygwin_shell', 1))) != 0

[scottmg, 2013-10-25 04:24:45]

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
File Source/build/ConvertFileToHeaderWithCharacterArray.gypi (right):

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
Source/build/ConvertFileToHeaderWithCharacterArray.gypi:56: ],
On 2013/10/25 04:16:35, abarth wrote:
> On 2013/10/25 04:14:31, Nico wrote:
> > Can this be
> > 
> >   'msvs_cygwin_shell': 0,
> > 
> > now?
> 
> Do we need to explicitly set this value to zero?  I've just been deleting it
> when moving scripts to Python.

gyp defaults it to 1 (whyyyyyy), but in Chromium the default is 0 now
http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=178146&r...

(It'd be great to just remove it entirely, but I think ffmpeg and libvpx and
maybe a few others "like" their bash scripts. NaCl has their own copy of cygwin
for better or worse, so at least that's not blocking.)

[scottmg, 2013-10-25 04:24:56]

(so, lgtm)

[Nils Barth (inactive), 2013-10-25 07:22:35]

Thanks all; revised and landing.

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
File Source/build/ConvertFileToHeaderWithCharacterArray.gypi (right):

https://codereview.chromium.org/42793005/diff/1/Source/build/ConvertFileToHea...
Source/build/ConvertFileToHeaderWithCharacterArray.gypi:56: ],
Thanks all!
Added
'msvs_cygwin_shell': 0,
...as appears necessary, per Scott.

https://codereview.chromium.org/42793005/diff/1/Source/build/scripts/xxd.py
File Source/build/scripts/xxd.py (right):

https://codereview.chromium.org/42793005/diff/1/Source/build/scripts/xxd.py#n...
Source/build/scripts/xxd.py:38: return args
On 2013/10/25 04:14:31, Nico wrote:
> Why not just `return sys.argv[1:]`? What does the optparse add?

Good point, thanks!
I was just using optparse by default,
but you're right, it's not needed here.

https://codereview.chromium.org/42793005/diff/1/Source/core/core_derived_sour...
File Source/core/core_derived_sources.gyp (right):

https://codereview.chromium.org/42793005/diff/1/Source/core/core_derived_sour...
Source/core/core_derived_sources.gyp:131: 'msvs_cygwin_shell': 0,
On 2013/10/25 04:16:35, abarth wrote:
> Whatever we decide, we should be consistent here.

Got it;
including (as necessary),
and reformatted so in consistent place
(at end of list)

[commit-bot: I haz the power, 2013-10-25 07:23:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/42793005/120001

[commit-bot: I haz the power, 2013-10-25 07:50:56]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Nils Barth (inactive), 2013-10-25 07:56:43]

On 2013/10/25 07:50:56, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on win_blink_rel.

Python 2.6 on Windows (and Mac), so need {0} in format strings, not {}.
Fixed.

[commit-bot: I haz the power, 2013-10-25 07:57:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/42793005/250001

[commit-bot: I haz the power, 2013-10-25 09:30:52]

Change committed as 160558