Abstract out fetching of break_address in debug mode

src/arm/assembler-arm.h

Index: src/arm/assembler-arm.h
diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h
index e0b89a5d86cc2999b81609946b8f48eb386a9f29..0b826d4a89ba9b1c67f4e18e36edbb21d3c7ed7c 100644
--- a/src/arm/assembler-arm.h
+++ b/src/arm/assembler-arm.h
@@ -810,6 +810,9 @@ class Assembler : public AssemblerBase {
 
   static const int kPatchDebugBreakSlotReturnOffset = 2 * kInstrSize;
 
+  // Return the code target address of the patch debug break slot
+  inline static Address break_address_from_break_address(Address pc);

[rmcilroy, 2014/07/30 10:05:36]

Please use the INLINE() macro and move up to be below
return_address_from_call_start (for all arches).  Also, I think it should be
called break_address_from_return_address.

[andrew_low, 2014/07/30 14:06:46]

Done.

+
   // Difference between address of current opcode and value read from pc
   // register.
   static const int kPcLoadDelta = 8;