src/arm/assembler-arm-inl.h - Issue 427863003: Abstract out fetching of break_address in debug mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/assembler-arm-inl.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: update to catch 2nd usage Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/assembler-arm-inl.h

diff --git a/src/arm/assembler-arm-inl.h b/src/arm/assembler-arm-inl.h

index 292885d1b248d99a358db9de9d13a28ebae8cd81..0e81742d5389665fe50ef5541151d505b2c214d1 100644

--- a/src/arm/assembler-arm-inl.h

+++ b/src/arm/assembler-arm-inl.h

@@ -458,6 +458,11 @@ Address Assembler::target_address_from_return_address(Address pc) {

}

+Address Assembler::break_address_from_break_address(Address pc) {

+ return pc - Assembler::kPatchDebugBreakSlotReturnOffset;

Address Assembler::return_address_from_call_start(Address pc) {

if (IsLdrPcImmediateOffset(Memory::int32_at(pc)) |

IsLdrPpImmediateOffset(Memory::int32_at(pc))) {