Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 427823002: Remove gpu support for willUseHWAALines. (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove support in the gpu to use hardware AA lines. Current code paths could not reach this code and thus was never used. The blend opt flag kDisableBlend should now be able to be removed, however it is left in this CL and will removed in its own. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b414f25cf97a690034a180a2c704b4b3935b8ed0

Patch Set 1 #

Patch Set 2 : Remove all smooth line references #

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -107 lines) Patch
M include/gpu/GrTypes.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 1 chunk +1 line, -9 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 chunks +33 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
egdaniel
Same removal of the HWAALines as before, but this time I did not remove the ...
6 years, 4 months ago (2014-07-29 19:52:19 UTC) #1
egdaniel
Same removal of the HWAALines as before, but this time I did not remove the ...
6 years, 4 months ago (2014-07-29 19:52:19 UTC) #2
bsalomon
lgtm
6 years, 4 months ago (2014-07-29 19:54:41 UTC) #3
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-07-29 20:01:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/427823002/40001
6 years, 4 months ago (2014-07-29 20:01:45 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 20:15:54 UTC) #6
Message was sent while issue was closed.
Change committed as b414f25cf97a690034a180a2c704b4b3935b8ed0

Powered by Google App Engine
This is Rietveld 408576698