Cast: Remove unused RTCP messages

Cast: Remove unused RTCP messages

Removing the following unused RTCP messages:
* PLI
* NACK
* RPSI
* REMB
* BYE
* SDES

Deleted about 1200 lines of code. Tested with cast_unittests
and simulation shows no difference. Casting to a proper
receiver works as well.

BUG=393042, 396207
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287142

[hubbe, 2014-07-30 19:29:59]

lgtm

[acolwell GONE FROM CHROMIUM, 2014-07-30 19:52:47]

Drive-by comment. I'm surprised you are allowed to remove SDES. Are you not
intending to maintain RFC 3550 compliance? SDES w/ a CNAME is required for all
compound RTCP packets.

[Alpha Left Google, 2014-07-30 20:01:10]

On 2014/07/30 19:52:47, acolwell wrote:
> Drive-by comment. I'm surprised you are allowed to remove SDES. Are you not
> intending to maintain RFC 3550 compliance? SDES w/ a CNAME is required for all
> compound RTCP packets.

No we're not intending to be RFC 3550 compliant.

[acolwell GONE FROM CHROMIUM, 2014-07-30 20:07:02]

On 2014/07/30 20:01:10, Alpha wrote:
> On 2014/07/30 19:52:47, acolwell wrote:
> > Drive-by comment. I'm surprised you are allowed to remove SDES. Are you not
> > intending to maintain RFC 3550 compliance? SDES w/ a CNAME is required for
all
> > compound RTCP packets.
> 
> No we're not intending to be RFC 3550 compliant.

You might want to consider dropping RTCP from the names then so people don't
assume this code actually represents a compliant RTCP implementation. Obviously
in a different CL.

[Alpha Left Google, 2014-07-30 20:22:46]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-30 20:24:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/20001

[Alpha Left Google, 2014-07-30 20:25:50]

> You might want to consider dropping RTCP from the names then so people don't
> assume this code actually represents a compliant RTCP implementation.
Obviously
> in a different CL.

In many cast does not work with a typical RTP sender/receiver but the message
wire format is still based on RTP/RTCP. But yes removing the name RTP/RTCP is a
possibly. This change is only for cleanup to remove unused code paths.

[commit-bot: I haz the power, 2014-07-30 21:37:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-07-30 21:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 21:41:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alpha Left Google, 2014-07-31 02:18:21]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-31 02:20:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/20001

[commit-bot: I haz the power, 2014-07-31 02:26:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-07-31 02:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 02:31:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alpha Left Google, 2014-07-31 07:16:16]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-31 07:18:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/20001

[commit-bot: I haz the power, 2014-07-31 07:24:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-07-31 07:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 07:29:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alpha Left Google, 2014-07-31 17:52:50]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-31 17:54:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/20001

[commit-bot: I haz the power, 2014-07-31 17:58:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-07-31 18:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 18:01:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alpha Left Google, 2014-07-31 20:43:43]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-31 20:45:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/40001

[commit-bot: I haz the power, 2014-07-31 21:58:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36102)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-31 22:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-31 22:02:23]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36164)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Alpha Left Google, 2014-07-31 22:38:49]

The CQ bit was checked by hclam@chromium.org

[Alpha Left Google, 2014-07-31 22:38:49]

The CQ bit was unchecked by hclam@chromium.org

[Alpha Left Google, 2014-07-31 22:38:50]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-31 22:39:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/60001

[commit-bot: I haz the power, 2014-08-01 06:22:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-01 06:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 06:28:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alpha Left Google, 2014-08-01 06:46:45]

+tsepez for cast_messages.h

[Tom Sepez, 2014-08-01 16:03:27]

Rubberstamp LGTM on deleting member from messages.  Thank you for the cleanup.

[Alpha Left Google, 2014-08-01 18:30:40]

The CQ bit was checked by hclam@chromium.org

[Alpha Left Google, 2014-08-01 18:31:36]

On 2014/08/01 16:03:27, Tom Sepez wrote:
> Rubberstamp LGTM on deleting member from messages.  Thank you for the cleanup.

No problem! I'll do another pass to the parsing logic.

[commit-bot: I haz the power, 2014-08-01 18:32:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/427733002/60001

[commit-bot: I haz the power, 2014-08-02 01:21:51]

Change committed as 287142