Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: media/cast/net/rtcp/rtcp_sender.h

Issue 427733002: Cast: Remove unused RTCP messages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/net/rtcp/rtcp_receiver_unittest.cc ('k') | media/cast/net/rtcp/rtcp_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/net/rtcp/rtcp_sender.h
diff --git a/media/cast/net/rtcp/rtcp_sender.h b/media/cast/net/rtcp/rtcp_sender.h
index e55d5f4234bc5f7555e9bdabcf82817efeee4e1f..bfbd0cf3b6493ab65d5a4d8a215a9e32f8bf6a86 100644
--- a/media/cast/net/rtcp/rtcp_sender.h
+++ b/media/cast/net/rtcp/rtcp_sender.h
@@ -45,8 +45,7 @@ class PacedPacketSender;
class RtcpSender {
public:
RtcpSender(PacedPacketSender* outgoing_transport,
- uint32 sending_ssrc,
- const std::string& c_name);
+ uint32 sending_ssrc);
~RtcpSender();
// TODO(hclam): This method should be to build a packet instead of
@@ -72,18 +71,6 @@ class RtcpSender {
void AddReportBlocks(const RtcpReportBlock& report_block,
Packet* packet) const;
- void BuildSdec(Packet* packet) const;
-
- void BuildPli(uint32 remote_ssrc, Packet* packet) const;
-
- void BuildRemb(const RtcpRembMessage* remb, Packet* packet) const;
-
- void BuildRpsi(const RtcpRpsiMessage* rpsi, Packet* packet) const;
-
- void BuildNack(const RtcpNackMessage* nack, Packet* packet) const;
-
- void BuildBye(Packet* packet) const;
-
void BuildRrtr(const RtcpReceiverReferenceTimeReport* rrtr,
Packet* packet) const;
@@ -107,24 +94,9 @@ class RtcpSender {
size_t* total_number_of_messages_to_send,
size_t* rtcp_log_size);
- inline void BitrateToRembExponentBitrate(uint32 bitrate,
- uint8* exponent,
- uint32* mantissa) const {
- // 6 bit exponent and a 18 bit mantissa.
- *exponent = 0;
- for (int i = 0; i < 64; ++i) {
- if (bitrate <= (262143u << i)) {
- *exponent = i;
- break;
- }
- }
- *mantissa = (bitrate >> *exponent);
- }
-
const uint32 ssrc_;
- const std::string c_name_;
- // Not owned by this class.
+ // Not owned by this class.
PacedPacketSender* const transport_;
std::deque<RtcpReceiverLogMessage> rtcp_events_history_;
« no previous file with comments | « media/cast/net/rtcp/rtcp_receiver_unittest.cc ('k') | media/cast/net/rtcp/rtcp_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698