Enable ES6 Map and Set by default

Enable ES6 Map and Set by default

In doing so also remove all references to the --harmony-collections flag.
Due to the way context snapshotting works, it's not possible to simply
enable the flag by default.

Depends on ES6 Symbols: https://codereview.chromium.org/421313004

BUG=v8:1622
LOG=Y
R=arv@chromium.org, rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22889

[adamk, 2014-07-29 22:31:01]

Note that this depends on https://codereview.chromium.org/421313004 being
submitted first. It passes try jobs (see
https://codereview.chromium.org/429433003).

[adamk, 2014-08-01 22:11:03]

Ping on this review, too, now that Symbols have been LGTM'd this could land
right after.

Note that the one bit I'm not sure about is in test/mjsunit/builtins.js: I had
to hack around it for the iterators, but I'm not entirely clear what the test is
protecting against.

[adamk, 2014-08-04 18:37:59]

Now rebased against bleeding_edge, to tryjobs should work here. Please take a
look.

[arv (Not doing code reviews), 2014-08-04 18:42:02]

Non owner LGTM

[rossberg, 2014-08-05 12:56:54]

LGTM with two comments:

- You should also adjust BUILD.gn
- Please remove the now obsolete test/mjsunit/es6/weak-collections.js

[adamk, 2014-08-05 19:26:35]

Updated with BUILD.gn fixes and removal of weak-collections test.

[adamk, 2014-08-05 19:37:45]

Committed patchset #4 manually as 22889 (presubmit successful).

[adamk, 2014-08-06 00:21:15]

On 2014/08/05 at 19:37:45, adamk wrote:
> Committed patchset #4 manually as 22889 (presubmit successful).

It's possible that this broke a test on arm64:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...

=== cctest/test-compiler/OptimizedCodeSharing ===
--- stderr ---
#
# Fatal error in ../test/cctest/test-compiler.cc, line 390
# CHECK(fun1->IsOptimized() || !CcTest::i_isolate()->use_crankshaft() ||
!fun1->IsOptimizable()) failed
#

But I can't reproduce this locally. If it persists on the waterfall in MUC
daytime feel free to revert.

[adamk, 2014-08-06 17:33:34]

On 2014/08/06 at 00:21:15, adamk wrote:
> On 2014/08/05 at 19:37:45, adamk wrote:
> > Committed patchset #4 manually as 22889 (presubmit successful).
> 
> It's possible that this broke a test on arm64:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...
> 
> === cctest/test-compiler/OptimizedCodeSharing ===
> --- stderr ---
> #
> # Fatal error in ../test/cctest/test-compiler.cc, line 390
> # CHECK(fun1->IsOptimized() || !CcTest::i_isolate()->use_crankshaft() ||
!fun1->IsOptimizable()) failed
> #
> 
> But I can't reproduce this locally. If it persists on the waterfall in MUC
daytime feel free to revert.

And it seems to have gone away on the tree. Nothing to see here.