Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 421313004: Enable ES6 Symbols by default (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
CC:
arv (Not doing code reviews), Dmitry Lomov (no reviews), v8-dev
Project:
v8
Visibility:
Public.

Description

Enable ES6 Symbols by default In doing so also remove all references to the --harmony-symbols flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. BUG=v8:2158 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -46 lines) Patch
M src/bootstrapper.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M src/d8.js View 1 chunk +1 line, -4 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/v8natives.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/mirror-symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-crbug-346141.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/iteration-semantics.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/set-prototype-of.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/proto-accessor.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-350864.js View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
adamk
6 years, 4 months ago (2014-07-28 22:47:37 UTC) #1
adamk
Note that this is a necessary step for enabling Maps and Sets as well (which ...
6 years, 4 months ago (2014-07-28 23:15:55 UTC) #2
danno
FYI, Andreas is on vacation until Thursday, so it will be a day or two ...
6 years, 4 months ago (2014-07-29 08:18:04 UTC) #3
adamk
Review ping? Would like to get these some bake time in Canary before the branch ...
6 years, 4 months ago (2014-08-01 21:36:38 UTC) #4
Dmitry Lomov (no reviews)
lgtm
6 years, 4 months ago (2014-08-01 21:58:27 UTC) #5
Dmitry Lomov (no reviews)
lgtm
6 years, 4 months ago (2014-08-01 21:58:28 UTC) #6
adamk
On 2014/08/01 at 21:58:28, dslomov wrote: > lgtm Thanks. Looks like I should wait to ...
6 years, 4 months ago (2014-08-01 22:08:06 UTC) #7
adamk
Committed patchset #1 manually as 22831 (presubmit successful).
6 years, 4 months ago (2014-08-04 18:18:06 UTC) #8
rossberg
Hi Adam, sorry, I had my vacation extended by 2 days. I actually had the ...
6 years, 4 months ago (2014-08-04 19:32:15 UTC) #9
adamk
6 years, 4 months ago (2014-08-04 19:47:14 UTC) #10
Message was sent while issue was closed.
On 2014/08/04 at 19:32:15, rossberg wrote:
> Hi Adam, sorry, I had my vacation extended by 2 days.
> 
> I actually had the same CL finished before my vacation, but couldn't land it:
> 
> https://codereview.chromium.org/405803006/
> 
> From a cursory look it seems they are equivalent. :)

Ah, I didn't see that one, sorry for the duplication. I put together this one to
unblock enabling Maps/Sets.

Powered by Google App Engine
This is Rietveld 408576698