Issue 4277: Remove two cases of needlessly jumping to the next instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4277: Remove two cases of needlessly jumping to the next instruction. (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

Remove two cases of needlessly jumping to the next instruction. The jump eliminator will remove these cases, but it's easy enough to just do statically in the code, and not require the eliminator to do it at runtime.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/codegen-ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

12 years, 3 months ago (2008-09-25 16:18:15 UTC) #1

I just set a breakpoint on the jump to next eliminator, and only found these two
cases ever get it.  If it makes the control flow too confusing (the switch one
is a big of a monster), I'm up for leaving it as is.  Leaving the jump to next
optimization is simple, but I want to get rid of the other stuff.

Expand Messages | Collapse Messages