Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/codegen-ia32.cc

Issue 4277: Remove two cases of needlessly jumping to the next instruction. (Closed)
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
diff --git a/src/codegen-ia32.cc b/src/codegen-ia32.cc
index 1c6fc5b2c696007bd7426d562871a9cd896d1b28..4f237ea1a51132ead91b30ac4fb6525ff108cf49 100644
--- a/src/codegen-ia32.cc
+++ b/src/codegen-ia32.cc
@@ -1127,7 +1127,7 @@ void ToBooleanStub::Generate(MacroAssembler* masm) {
__ sahf();
__ pop(eax);
__ j(zero, &false_result);
- __ jmp(&true_result);
+ // Fall through to |true_result|.
// Return 1/0 for true/false in eax.
__ bind(&true_result);
@@ -1492,7 +1492,7 @@ void GenericBinaryOpStub::Generate(MacroAssembler* masm) {
__ bind(&slow);
__ mov(eax, Operand(esp, 1 * kPointerSize));
__ mov(edx, Operand(esp, 2 * kPointerSize));
- __ jmp(&call_runtime);
+ // Fall through to |call_runtime|.
break;
}
case Token::BIT_OR:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698